1059306 - Failure summaries that contain a term in the blacklist are blank

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central&revision=4f6affdf52b6
-> no error summary shown

TBPL:
https://tbpl.mozilla.org/?rev=4f6affdf52b6

https://tbpl.mozilla.org/php/getParsedLog.php?id=46810047&tree=Mozilla-Central

17:39:28  WARNING -  TEST-UNEXPECTED-FAIL | automation.py | Exited with code 1 during test run
17:39:59  WARNING -  PROCESS-CRASH | automation.py | application crashed [@ nsIOService::GetManageOfflineStatus(bool*)]
17:39:59    ERROR - Return code: 1

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: Bug suggestion artifact

Comment 2

[Ed Morley [:emorley]]

Is it the "bugs": null ?

Should we return:
		"bugs": {
			"open_recent": [],
			"all_others": []
		}

Comment 3

[Mauro Doglio [:mdoglio]]

The UI code generates an error when an error line in a bug suggestions artifact has a bugs attribute null. I guess the null value is generated in case of a blacklisted term in the error line. We can either update the UI to accept null values for that or change the parse-log task to produce 
> {"open_recent": [],"all_others": [ ]}
like the other error lines without suggestions.
See the attachment for details

Comment 4

[Ed Morley [:emorley]]

Attachment: treeherder-service/pull/193

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8480431 [details] [review]
treeherder-service/pull/193

Cameron reviewed this and merged it:

https://github.com/mozilla/treeherder-service/commit/be1c0614068db3ebe561b7384a21d5d5107a0905

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/f29d7360c91d0d3b132484b840da1c9cb7dd18a7
Bug 1059306 - Remove temporary workaround added by bug 1059949

Enough time has passed now, that the jobs affected by bug 1059306 have
either been purged, or are not being accessed via the UI. As such, the
workaround to handle the bad bug suggestion artefact can be removed.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ac1b25c15f48eadc1da8a2f0c9fc9bdb48506b1b
Bug 1059306 - Remove temporary workaround added by bug 1059949

Enough time has passed now, that the jobs affected by bug 1059306 have
either been purged, or are not being accessed via the UI. As such, the
workaround to handle the bad bug suggestion artefact can be removed.