Closed Bug 1059949 Opened 7 years ago Closed 7 years ago
treeherder-ui should handle suggestion
.bugs being null more gracefully
The fix for bug 1059306 doesn't apply to previously parsed logs - to help with those we could just handle this more gracefully in the UI: "Error: suggestion.bugs is null update_bugs/</<@https://treeherder.allizom.org/ui/js/index.min.js:19:18184 forEach@https://treeherder.allizom.org/ui/js/index.min.js:4:31160 update_bugs/<@https://treeherder.allizom.org/ui/js/index.min.js:19:18133 qFactory/defer/deferred.promise.then/wrappedCallback@https://treeherder.allizom.org/ui/js/index.min.js:7:26466 qFactory/ref/<.then/<@https://treeherder.allizom.org/ui/js/index.min.js:7:27876 $RootScopeProvider/this.$get</Scope.prototype.$eval@https://treeherder.allizom.org/ui/js/index.min.js:8:4393 $RootScopeProvider/this.$get</Scope.prototype.$digest@https://treeherder.allizom.org/ui/js/index.min.js:8:2247 $RootScopeProvider/this.$get</Scope.prototype.$apply@https://treeherder.allizom.org/ui/js/index.min.js:8:4818 done@https://treeherder.allizom.org/ui/js/index.min.js:7:2339 completeRequest@https://treeherder.allizom.org/ui/js/index.min.js:7:6224 createHttpBackend/</xhr.onreadystatechange@https://treeherder.allizom.org/ui/js/index.min.js:7:7168 " https://github.com/mozilla/treeherder-ui/blob/c1abd6237b4d00684b1c410728309e3f12a2c181/webapp/app/plugins/failure_summary/controller.js#L41
I'm not sure what to do with this - either we use something hacky like this patch and remove it at a later date (given the service is now fixed), or we add more complete checking for missing properties. (But for the latter, we don't do this for everything else, and seems like we're at risk of bloating the UI code if we do it across the board).
Jonathan/Cameron, would either of you mind taking the review for this? (Didn't realise Mauro was away)
Attachment #8480787 - Flags: review+
Comment on attachment 8480787 [details] [diff] [review] Patch v1 https://github.com/mozilla/treeherder-ui/commit/0bdb50c7f6a49da7ea680ea85fd0ac546f2fae99 Thank you - I'll file another bug for implementing more thorough json schema validation in the ui.
Attachment #8480787 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Ed Morley [:edmorley] from comment #6) > Thank you - I'll file another bug for implementing more thorough json > schema validation in the ui. Actually bug 1043338 is already filed for this.
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/a222d4575502e790c07c7dcb79f52d4cd6fe3c70 Bug 1059949 - Handle bugs not having open_recent and all_other keys more gracefully; r=mdoglio For a short time, treeherder-service was creating log artefacts that were missing the open_recent and all_other keys on the bugs property. This likely temporary workaround will let us view the summaries for those jobs until enough time has passed that we no longer care about them.
You need to log in before you can comment on or make changes to this bug.