1060058 - Logviewer: Successful steps don't collapse as well as Failure steps at small sizes

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

At extremely small browser widths, when showing Successful steps, the green passed step elements don't collapse down to the same degree (ie as well as) as the Failed steps do. As a result the green pass step elements will overflow off screen.

This was an acknowledged minor nuisance, agreed to in the process of fixing the major blocker bug 1042466 in the drive to burn down all our blocker bugs.

We can address this nit with this bug, if it is possible to do so.

I will attach a screen grab of the desired appearance vs. the current appearance.

Comment 1

[Jonathan French (:jfrench)]

Attachment: desiredCollapse-vs-CurrentBehavior

Comment 2

[Mauro Doglio [:mdoglio]]

Attachment: PR 303 on Treeherder UI

Comment 3

[Rakesh]

:camd, can you go through the patch I have submitted.

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8536580 [details] [review]
PR 303 on Treeherder UI

Hi there--  I found a couple bugs and commented in the PR on github.  Thanks!
-Cam

Comment 5

[Rakesh]

Hi camd, I have worked on the bugs and commited them. 

https://github.com/dewgeek/treeherder-ui/tree/master

please review the changes

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/c7d10090a01e13f11438fd60ffe3b470e4f7a15d
Bug 1060058 - clipping of logviewer UI in smaller browsers

https://github.com/mozilla/treeherder-ui/commit/be485da6996fcc230e5f44528c1fde81f72cc964
Merge pull request #303 from dewgeek/master

Bug 1060058 - clipping of logviewer UI in smaller browsers is patched

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/993159dd1e1d35fd87341f278c1ee63801374750
Bug 1060058 - clipping of logviewer UI in smaller browsers

https://github.com/mozilla/treeherder/commit/1a89964ed32dad34895872991330a027dc356434
Merge pull request #303 from dewgeek/master

Bug 1060058 - clipping of logviewer UI in smaller browsers is patched