1060114 - Partial surface uploading though BufferTextureClient is broken

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

This looks like a regression from 1040187.

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/composite/TextureHost.cpp#364

mFirstSource->GetUpdateSerial() == mUpdateSerial will never be true since we've just bumped mUpdateSerial.

The mPartialUpdate part of the condition won't ever be true either since this is the only place we set it to true.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: fix-partial-upload

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8480927 [details] [diff] [review]
fix-partial-upload

Review of attachment 8480927 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but needs some comments.

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a8be49b5527

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a8be49b5527

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 8480927 [details] [diff] [review]
fix-partial-upload

Approval Request Comment
[Feature/regressing bug #]: OMTC
[User impact if declined]: Drawing artifacts
[Describe test coverage new/current, TBPL]: Nightly & Aurora
[Risks and why]: Required if we uplift the fix for bug 1040187
[String/UUID change made/needed]: None

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8480927 [details] [diff] [review]
fix-partial-upload

beta+. Approval already granted for bug 1040187. These changes will ship in beta2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/09d840603713

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Made a silly rebase error. Backed out and re-landed.
https://hg.mozilla.org/releases/mozilla-beta/rev/bca701646487