Closed Bug 1060162 Opened 6 years ago Closed 6 years ago

[RPP] parse the SMS

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
feature-b2g 2.2+

People

(Reporter: marta, Assigned: agnieszka.baranowska)

References

Details

(Keywords: privacy)

Attachments

(2 files)

If there is an incoming SMS we need to parse its contents and know if this is an RPP activation message.
Blocks: 1060163
Blocks: 1060164
Blocks: 1060166
Assignee: nobody → marta
Summary: RPP: parse the SMS → [RPP] parse the SMS
Keywords: privacy
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Assignee: marta → agnieszka.baranowska
QA Whiteboard: STATUS: Patch Landed
QA Whiteboard: STATUS: Patch Landed → STATUS: waiting for review
QA Whiteboard: STATUS: waiting for review → STATUS: ready for review
Need to change the SMS syntax and some responses:

- [RPP|rpp|Rpp] <CMD> <Passpharse>
- If the proper syntax is recognized but the password is wrong a message with the information should be sent back to the user, e.g. "We received your command but the password was wrong"
- If the proper syntax is recognized but the feature was not activated, a message with the information should be sent back to the user, e.g. "We received your command but you never activated it"
- The responses should contain a link to the support webpage.
- The SMS should be parsed with regex and not if clauses.
Implementation tested. SMS Message is parsed and handled correctly, but there is this problem:

observers for RPP settings change are not working properly. When the on/off toggle for any RPP feature is changed no console log '!!!!!!!!!!!!!! [fmdsms] new value: ...' is being displayed. This results in behavior that all variables which store values corresponding to the on/off toggles preserve the initial value from DB settings when the phone powers up. To perform tests with changed settings phone needs to be restarted.

Developer is informed about findings.
Attached file Test console log
Blocks: 1068043
Blocks: 1069915
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.2+
You need to log in before you can comment on or make changes to this bug.