[SETTINGS] Launch the Privacy Panel from Settings App

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: marta, Assigned: daniel.marecik)

Tracking

({privacy})

unspecified
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

5 years ago
Add a button to SettingsApp that lounches the PP, and a back button to PP main screen

Updated

5 years ago
Keywords: privacy
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All

Updated

5 years ago
Summary: Launch the Privacy Panel from Settings App → [SETTINGS] Launch the Privacy Panel from Settings App
Reporter

Updated

5 years ago
QA Whiteboard: STATUS: engineering design
Priority: -- → P4
Reporter

Updated

5 years ago
Priority: P4 → P3
Reporter

Updated

5 years ago
QA Whiteboard: STATUS: engineering design → STATUS: not started
Reporter

Updated

5 years ago
Assignee: marta → daniel.marecik
Reporter

Comment 1

5 years ago
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/developer.js
Sample code that launches the First Time Use app from the settings.
What should be done:
1. Implement a button in Settings App and connect the js file like the one above that launches the PP.
2. Implement a back button in PP, and connect the js file that looks like one above but launches settings.
Reporter

Updated

5 years ago
QA Whiteboard: STATUS: not started → STATUS: implementation work
Assignee

Comment 2

5 years ago
Assignee

Comment 3

5 years ago
Button in Settings App and js file were added.
Back button in PP and js file were added.

At the moment back button is always displayed. Finally the button should be displayed only, when PP is opened from Settings App.
Assignee

Comment 4

5 years ago
Attachment #8487000 - Attachment is obsolete: true
Reporter

Updated

5 years ago
QA Whiteboard: STATUS: implementation work → STATUS: ready for review
Priority: P3 → --
I know it's a hack, but in theory we could use the settings db to indicate when the PP is launched from settings.  Here's how:

0. The settings app creates/sets a settings db key-value-pair like:  privacy_panel.launched_from = settings.
1. The privacy panel app always checks for and clears the privacy_panel.launched_from settings db value when it starts up.
2. If the settings db value is "settings" then the back button is shown.  Otherwise, it is hidden.

The end result is that the back button will be shown whenever the settings app launches the privacy panel.  if the privacy panel is launched from the home screen the settings db key-value-pair will not be set and the back button won't be shown.
Reporter

Updated

5 years ago
Blocks: 1069915
Reporter

Updated

5 years ago
Blocks: 1071042
Reporter

Updated

5 years ago
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
feature-b2g: --- → 2.2+
You need to log in before you can comment on or make changes to this bug.