Closed Bug 1060177 Opened 6 years ago Closed 5 years ago

[ALA] Grid Algorithm

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
feature-b2g 2.2+

People

(Reporter: marta, Assigned: agnieszka.baranowska)

References

Details

(Keywords: privacy)

Attachments

(2 files, 1 obsolete file)

In order to have ALA we need to implement a grid algorithm that will return the middle of a cell in which the user is.
Blocks: 1060178
Blocks: 1060181
Attached patch Bug1060177.patchSplinter Review
Please see attachment Bug1060177.patch which delivers grid algorithm.
Summary: ALA: Grid Algorithm → [ALA] Grid Algorithm
Keywords: privacy
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Assignee: marta → agnieszka.baranowska
QA Whiteboard: STATUS: Patch Landed
QA Whiteboard: STATUS: Patch Landed → STATUS: waiting for review
Comment on attachment 8483466 [details] [review]
https://github.com/mozilla/gecko-dev/pull/46

gecko-dev can't accept pull requests unfortunately, however the patch you've also attached here is the correct format to submit work to this project :-)
Attachment #8483466 - Attachment is obsolete: true
QA Whiteboard: STATUS: waiting for review → STATUS: ready for review
Blocks: 1063610
Can you please reformat this patch into the mercurial format?  In your .gitconfig add this:

[alias]
  hgpatch = show --binary --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8

Then run 'git hgpatch' to create the patch file.

Thanks!
Flags: needinfo?(agnieszka.baranowska)
Attached file Bug1060177.hgpatch
Flags: needinfo?(agnieszka.baranowska)
HG patch created
One last little detail.  You should have just named the new patch file Bug1060177.patch and when you attached it, there is a checkbox that says, "this attachment obsoletes: <dropdown box>"  You should have said that the new patch file obsoletes the previous patch file.  That way there would only be a single attachment and it would be the latest, properly formatted patch.

:)
Flags: needinfo?(agnieszka.baranowska)
Ok, I will remember about it next time.
Flags: needinfo?(agnieszka.baranowska)
Blocks: 1068044
Blocks: 1069915
Blocks: 1071042
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.2+
You need to log in before you can comment on or make changes to this bug.