Closed
Bug 1060229
Opened 10 years ago
Closed 10 years ago
[bluedroid] Get/SetProperty DiscoveryTimeout failed due to missing property length
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 unaffected)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
b2g-v2.0 | --- | fixed |
b2g-v2.0M | --- | fixed |
b2g-v2.1 | --- | unaffected |
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
Details
Attachments
(2 files, 1 obsolete file)
1.71 KB,
patch
|
Details | Diff | Splinter Review | |
1.71 KB,
patch
|
bajaj
:
approval-mozilla-b2g32+
|
Details | Diff | Splinter Review |
SetProperty DiscoveryTimeout failed due to missing property length.
This will make bluedroid write value failed and given GKI interface warning.
Due to bt_property_t of value length is missing.
Assignee | ||
Updated•10 years ago
|
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
I'm not sure v2.1 is affected since v2.1 refactoring totally. Need to check again.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8481104 -
Flags: review?(btian)
Comment 3•10 years ago
|
||
Comment on attachment 8481104 [details] [diff] [review]
Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length
Review of attachment 8481104 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8481104 -
Flags: review?(btian) → review+
Assignee | ||
Updated•10 years ago
|
Summary: [bluedroid] SetProperty DiscoveryTimeout failed due to missing property length → [bluedroid] Get/SetProperty DiscoveryTimeout failed due to missing property length
Updated•10 years ago
|
blocking-b2g: --- → 1.4+
Assignee | ||
Updated•10 years ago
|
Attachment #8481104 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → shuang
Assignee | ||
Updated•10 years ago
|
Attachment #8481166 -
Attachment description: Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length, r=btian → (v1.4) Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length, r=btian
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
This patch does not need to port bluetooth2 (BT API for v2.2).
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/e364fb0b4346
If this needs to land on v2.0 as well, you'll need to request b2g32 approval on the patch.
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → unaffected
Flags: needinfo?(shuang)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
Assignee | ||
Comment 8•10 years ago
|
||
Flags: needinfo?(shuang)
Assignee | ||
Comment 9•10 years ago
|
||
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bluedroid back-end support
User impact if declined: MCTS Bluetooth test case fail to pass
Testing completed:
Risk to taking this patch (and alternatives if risky): Low risk
String or UUID changes made by this patch: No
Attachment #8486179 -
Flags: approval-mozilla-b2g32?
Updated•10 years ago
|
Flags: needinfo?(btian)
Comment 10•10 years ago
|
||
Hey Kevin/shawn, why was this blocked on 1.4? How does this impact 2.0 or what exactly is the user impact here? IS this a regression we are trying to fix ? We do not want to add any risk on 2.0 at this point so please provide the comments on this being blocking the release.
Flags: needinfo?(khu)
Comment 11•10 years ago
|
||
Eric, can I have your comments here? Thanks!
Flags: needinfo?(khu) → needinfo?(echou)
Assignee | ||
Comment 12•10 years ago
|
||
Hi bhavana,
This will fix MCTS test case.
Comment 13•10 years ago
|
||
(In reply to Kevin Hu [:khu] from comment #11)
> Eric, can I have your comments here? Thanks!
I prefer picking this patch into 2.0. The main reason is because MCTS couldn't be passed without the patch. In addition the patch seems no harm to me (and not to mention this is a bug which might touch the invalid memory space).
Flags: needinfo?(echou)
Updated•10 years ago
|
Attachment #8486179 -
Flags: approval-mozilla-b2g32? → approval-mozilla-b2g32+
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
status-b2g-v2.0M:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•