1060229 - [bluedroid] Get/SetProperty DiscoveryTimeout failed due to missing property length

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

SetProperty DiscoveryTimeout failed due to missing property length.
This will make bluedroid write value failed and given GKI interface warning.
Due to bt_property_t of value length is missing.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I'm not sure v2.1 is affected since v2.1 refactoring totally. Need to check again.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length

Comment 3

[Ben Tian (inactive)]

Comment on attachment 8481104 [details] [diff] [review]
Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length

Review of attachment 8481104 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: (v1.4) Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length, r=btian

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This patch does not need to port bluetooth2 (BT API for v2.2).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/e364fb0b4346

If this needs to land on v2.0 as well, you'll need to request b2g32 approval on the patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Ben, does this need v2.0 uplift?

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://tbpl.mozilla.org/?tree=Try&rev=ed85ed140c7d

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: (v2.0) Bug 1060229 - [bluedroid] Set DiscoveryTimeout failed due to missing prop length, r=btian

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bluedroid back-end support
User impact if declined: MCTS Bluetooth test case fail to pass
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low risk
String or UUID changes made by this patch: No

Comment 10

[bhavana bajaj [:bajaj]]

Hey Kevin/shawn, why was this blocked on 1.4? How does this impact 2.0 or what exactly is the user impact here? IS this a regression we are trying to fix ?  We do not want to add any risk on 2.0 at this point so please provide the comments on this being blocking the release.

Comment 11

[Kai-Chih Hu [:khu]]

Eric, can I have your comments here? Thanks!

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi bhavana,
This will fix MCTS test case.

Comment 13

[Eric Chou [:ericchou] [:echou]]

(In reply to Kevin Hu [:khu] from comment #11)
> Eric, can I have your comments here? Thanks!

I prefer picking this patch into 2.0. The main reason is because MCTS couldn't be passed without the patch. In addition the patch seems no harm to me (and not to mention this is a bug which might touch the invalid memory space).

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/9d5f8415bd12

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/9d5f8415bd12