Closed
Bug 1060345
Opened 10 years ago
Closed 10 years ago
Create a way of dynamically inflating the correct tab layout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
(Whiteboard: [fixed-larch])
Attachments
(1 file, 1 obsolete file)
6.78 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Encapsulate the code surrounding which layout to use for displaying tabs
Comment 1•10 years ago
|
||
Maybe we want to use the same approach we used for BrowserToolbar? i.e. dynamically resolve class name on layout inflation level. See: http://hg.mozilla.org/projects/larch/rev/30a930761cb1
Assignee | ||
Updated•10 years ago
|
Summary: Create custom view which inflates the correct tab layout → Create a way of dynamically inflating the correct tab layout
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8484292 -
Flags: review?(lucasr.at.mozilla)
Comment 3•10 years ago
|
||
Comment on attachment 8484292 [details] [diff] [review] Create a way of dynamically inflating the correct tab layout Review of attachment 8484292 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with nit fixed. ::: mobile/android/base/BrowserApp.java @@ +236,5 @@ > final View view; > if (BrowserToolbar.class.getName().equals(name)) { > view = BrowserToolbar.create(context, attrs); > + } else if (TabsPanel.TabsLayout.class.getName().equals(name)) { > + view = TabsPanel.create(context, attrs); nit: Rename to createTabsLayout() for clarity.
Attachment #8484292 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Had to change the way we were defining the initial file in the XML as Fennec was crashing with runtime errors with the original method. This way seems fine though. https://tbpl.mozilla.org/?tree=Try&rev=15feaa66cd69
Attachment #8484292 -
Attachment is obsolete: true
Attachment #8485004 -
Flags: review?(lucasr.at.mozilla)
Comment 5•10 years ago
|
||
Comment on attachment 8485004 [details] [diff] [review] Create a way of dynamically inflating the correct tab layout Review of attachment 8485004 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch with the nits fixed. Please file a follow-up to audit all style names and ids to follow the new terminology. For instance, I saw that some TabsLayout instances in the layout files are using ids like 'private_tabs_tray' and styles like 'TabsList'. They should all converge to ...tabs_layout... or ...TabsLayout... ::: mobile/android/base/resources/layout/private_tabs_panel.xml @@ +47,4 @@ > > <!-- Note: for an unknown reason, scrolling in the TabsListLayout > does not work unless it is laid out after the empty view. --> > + <view class="org.mozilla.gecko.tabs.TabsPanel$TabsLayout" android:id="@+id/private_tabs_tray" nit: applies to all changed tags in this patch: align the rest of the attributes with the class attribute here. Something like: <view class="org.mozilla.gecko.tabs.TabsPanel$TabsLayout" android:id="+id/private_tabs_tray" ...
Attachment #8485004 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/a17eec723de5
Assignee | ||
Updated•10 years ago
|
Whiteboard: [fixed-larch]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a17eec723de5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•