1060496 - Support locale switching in search activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[:Margaret Leibovic]

See bug 1057631 comment 2. rnewman is the person to talk to about doing this (if he doesn't decide to take this bug himself!).

Comment 1

[Richard Newman [:rnewman]]

*yoink*

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

This relies on a small a-s/Fennec refactor; see dependencies.

Comment 3

[Richard Newman [:rnewman]]

Note that this is the most minimal change. There's no onConfigurationChanged handler, nor do we do locale processing in onResume. If these are needed, there will be two sets of symptoms:

* Strings might change during rotation, or toasts etc. produced after rotation will be in the wrong locale.
* Re-entering the activity after changing locales in Fennec (e.g., issue a search, switch locales, issue another search) won't reflect the current locale.

We can decide later (when we're actually able to test!) if we'd like a second pass at this to make the behavior more correct.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Make search activity locale-aware. v1

hg patch. Doesn't seem to regress anything; waiting on string movement and l10n to test properly.

Comment 5

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #3)
> Note that this is the most minimal change. There's no onConfigurationChanged
> handler, nor do we do locale processing in onResume. If these are needed,
> there will be two sets of symptoms:
> 
> * Strings might change during rotation, or toasts etc. produced after
> rotation will be in the wrong locale.
> * Re-entering the activity after changing locales in Fennec (e.g., issue a
> search, switch locales, issue another search) won't reflect the current
> locale.

We probably won't run into these until we fix bug 1060470, but we can file and fix as we encounter these issues. We should get proper localization working first! :)

Comment 6

[:Margaret Leibovic]

Comment on attachment 8481525 [details] [review]
Proposed patch. v1

You should have the power to merge this. I'll let you merge when you land your hg patch.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/e58cd57dde2f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e58cd57dde2f