Support locale switching in search activity

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
Search Activity
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: rnewman)

Tracking

Trunk
Firefox 35
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: shovel-ready)

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
See bug 1057631 comment 2. rnewman is the person to talk to about doing this (if he doesn't decide to take this bug himself!).
(Assignee)

Comment 1

3 years ago
*yoink*
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Depends on: 1060536
(Assignee)

Comment 2

3 years ago
Created attachment 8481525 [details] [review]
Proposed patch. v1

This relies on a small a-s/Fennec refactor; see dependencies.
Attachment #8481525 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 3

3 years ago
Note that this is the most minimal change. There's no onConfigurationChanged handler, nor do we do locale processing in onResume. If these are needed, there will be two sets of symptoms:

* Strings might change during rotation, or toasts etc. produced after rotation will be in the wrong locale.
* Re-entering the activity after changing locales in Fennec (e.g., issue a search, switch locales, issue another search) won't reflect the current locale.

We can decide later (when we're actually able to test!) if we'd like a second pass at this to make the behavior more correct.
(Assignee)

Comment 4

3 years ago
Created attachment 8481562 [details] [diff] [review]
Make search activity locale-aware. v1

hg patch. Doesn't seem to regress anything; waiting on string movement and l10n to test properly.
Attachment #8481562 - Flags: review?(margaret.leibovic)
(Reporter)

Comment 5

3 years ago
(In reply to Richard Newman [:rnewman] from comment #3)
> Note that this is the most minimal change. There's no onConfigurationChanged
> handler, nor do we do locale processing in onResume. If these are needed,
> there will be two sets of symptoms:
> 
> * Strings might change during rotation, or toasts etc. produced after
> rotation will be in the wrong locale.
> * Re-entering the activity after changing locales in Fennec (e.g., issue a
> search, switch locales, issue another search) won't reflect the current
> locale.

We probably won't run into these until we fix bug 1060470, but we can file and fix as we encounter these issues. We should get proper localization working first! :)
(Reporter)

Updated

3 years ago
Attachment #8481562 - Flags: review?(margaret.leibovic) → review+
(Reporter)

Comment 6

3 years ago
Comment on attachment 8481525 [details] [review]
Proposed patch. v1

You should have the power to merge this. I'll let you merge when you land your hg patch.
Attachment #8481525 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/e58cd57dde2f
https://hg.mozilla.org/mozilla-central/rev/e58cd57dde2f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.