Closed Bug 1060496 Opened 6 years ago Closed 6 years ago

Support locale switching in search activity

Categories

(Firefox for Android Graveyard :: Search Activity, defect, P1)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: Margaret, Assigned: rnewman)

References

Details

(Whiteboard: shovel-ready)

Attachments

(2 files)

See bug 1057631 comment 2. rnewman is the person to talk to about doing this (if he doesn't decide to take this bug himself!).
*yoink*
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Depends on: 1060536
Attached file Proposed patch. v1
This relies on a small a-s/Fennec refactor; see dependencies.
Attachment #8481525 - Flags: review?(margaret.leibovic)
Note that this is the most minimal change. There's no onConfigurationChanged handler, nor do we do locale processing in onResume. If these are needed, there will be two sets of symptoms:

* Strings might change during rotation, or toasts etc. produced after rotation will be in the wrong locale.
* Re-entering the activity after changing locales in Fennec (e.g., issue a search, switch locales, issue another search) won't reflect the current locale.

We can decide later (when we're actually able to test!) if we'd like a second pass at this to make the behavior more correct.
hg patch. Doesn't seem to regress anything; waiting on string movement and l10n to test properly.
Attachment #8481562 - Flags: review?(margaret.leibovic)
(In reply to Richard Newman [:rnewman] from comment #3)
> Note that this is the most minimal change. There's no onConfigurationChanged
> handler, nor do we do locale processing in onResume. If these are needed,
> there will be two sets of symptoms:
> 
> * Strings might change during rotation, or toasts etc. produced after
> rotation will be in the wrong locale.
> * Re-entering the activity after changing locales in Fennec (e.g., issue a
> search, switch locales, issue another search) won't reflect the current
> locale.

We probably won't run into these until we fix bug 1060470, but we can file and fix as we encounter these issues. We should get proper localization working first! :)
Attachment #8481562 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8481525 [details] [review]
Proposed patch. v1

You should have the power to merge this. I'll let you merge when you land your hg patch.
Attachment #8481525 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/e58cd57dde2f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.