Closed Bug 1060525 Opened 5 years ago Closed 5 years ago

Various string changes for Loop based on UX feedback

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox34 fixed)

RESOLVED FIXED
mozilla34
Iteration:
34.3
Tracking Status
firefox34 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file, 1 obsolete file)

`start_call` was unreferenced in the source tree, so I've removed it. As part of removing `start_call`, I also removed it from the 'fr' translation.

I added `start_call_no_identity` and `start_call_identity` per the UX request.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8481486 - Flags: review?(standard8)
This includes the other strings referenced in https://etherpad.mozilla.org/ep/pad/view/tY4SmRoKsi/rev.5863 except for bug 1060525.
Attachment #8481486 - Attachment is obsolete: true
Attachment #8481486 - Flags: review?(standard8)
Attachment #8482082 - Flags: review?(MattN+bmo)
s/except for bug 1060525/except for bug 1060452/
Summary: Add some strings for starting calls → Various string changes for Loop based on UX feedback
Comment on attachment 8482082 [details] [diff] [review]
Patch with more strings

Review of attachment 8482082 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/standalone/content/l10n/data.ini
@@ +1,3 @@
>  ## LOCALIZATION NOTE: In this file, don't translate the part between {{..}}
>  [en]
> +restart_call=Rejoin

Some strings, like this one, are not referenced in the code yet, but are in this patch so that they can be referenced by code that may be uplifted.
Comment on attachment 8482082 [details] [diff] [review]
Patch with more strings

Review of attachment 8482082 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8482082 - Flags: review?(MattN+bmo) → review+
Flags: qe-verify-
Flags: firefox-backlog+
Iteration: 34.3 → 35.1
https://hg.mozilla.org/mozilla-central/rev/43aa410f0108
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla34
Iteration: 35.1 → 34.3
You need to log in before you can comment on or make changes to this bug.