Closed
Bug 1060525
Opened 10 years ago
Closed 10 years ago
Various string changes for Loop based on UX feedback
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox34 fixed)
Tracking | Status | |
---|---|---|
firefox34 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file, 1 obsolete file)
18.25 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
`start_call` was unreferenced in the source tree, so I've removed it. As part of removing `start_call`, I also removed it from the 'fr' translation. I added `start_call_no_identity` and `start_call_identity` per the UX request.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8481486 -
Flags: review?(standard8)
Assignee | ||
Comment 2•10 years ago
|
||
This includes the other strings referenced in https://etherpad.mozilla.org/ep/pad/view/tY4SmRoKsi/rev.5863 except for bug 1060525.
Attachment #8481486 -
Attachment is obsolete: true
Attachment #8481486 -
Flags: review?(standard8)
Attachment #8482082 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 3•10 years ago
|
||
s/except for bug 1060525/except for bug 1060452/
Assignee | ||
Updated•10 years ago
|
Summary: Add some strings for starting calls → Various string changes for Loop based on UX feedback
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8482082 [details] [diff] [review] Patch with more strings Review of attachment 8482082 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/loop/standalone/content/l10n/data.ini @@ +1,3 @@ > ## LOCALIZATION NOTE: In this file, don't translate the part between {{..}} > [en] > +restart_call=Rejoin Some strings, like this one, are not referenced in the code yet, but are in this patch so that they can be referenced by code that may be uplifted.
Comment 5•10 years ago
|
||
Comment on attachment 8482082 [details] [diff] [review] Patch with more strings Review of attachment 8482082 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8482082 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/43aa410f0108
Whiteboard: [fixed in fx-team]
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify-
Flags: firefox-backlog+
Updated•10 years ago
|
Iteration: 34.3 → 35.1
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/43aa410f0108
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla34
Assignee | ||
Updated•10 years ago
|
Iteration: 35.1 → 34.3
status-firefox34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•