1060728 - Add perltidyrc that makes it easier to follow existing code standards to BMO repository

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Attachment: .perltidyrc

I would like to suggest inclusion of the attached perltidyrc file (or one similar to it, I remember that glob had made some suggested improvements to the options) in the bmo repository (and perhaps eventually upstream?) for the sake of consistency and easing developer contributions.

It would also prevent me from periodically losing it when I do git clean -df...

We could do this as a trial, and if the results are good, move it to upstream?
(my perltidyrc for upstream is a bit different, as there are slightly laxer guidelines at play in BMO)

Comment 1

[:glob ✱]

> Add perltidyrc that enforces existing code standards to BMO repository

including that file in our repo is a great idea :)

however you suggest in the summary enforcing the standards from this file.

given the current state of the code i don't think that enforcement would be appropriate at this point.  i'd _love_ to be able to enforce code standards via perltidy, but that needs to happen upstream first, and there's resistance to that idea there.

can you provide some more detail around what you mean by "enforc[ing]" ?

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Perhaps "reinforces" would be more correct, I didn't mean to imply it would be *required* to use, just that it would help ensure we *can* follow the guidelines.

Comment 3

[:glob ✱]

ok.  r=glob ship it.

Comment 4

[:glob ✱]

.. before you commit can you please use the long form of the switches for all options.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   caa8040..2c4c96b  master -> master