Closed
Bug 1060840
Opened 10 years ago
Closed 10 years ago
Closing a tab with an open toolbox seems to leak its frames
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.23 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Looking at bug 1000311, bug 1060836, bug 1060837 there seems to be a general problem with closing a tab with the toolbox open.
|
Assignee | |
Comment 1•10 years ago
|
||
Those aren't real leaks but are caused by the fact that destroying a toolbox is async.
|
||
Comment 2•10 years ago
|
||
forceGC at end of test ?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Not quite as easy :) We force CC/GC multiple times before checking.
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
Here's a try run with --per-dir:
https://tbpl.mozilla.org/?tree=Try&rev=c4864714cb1a
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8481957 [details] [diff] [review]
0002-Bug-1060840-Make-the-shutdown-leak-detector-wait-unt.patch
Review of attachment 8481957 [details] [diff] [review]:
-----------------------------------------------------------------
Pretty.
Attachment #8481957 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
The API changed a little but we're basically doing the same.
Attachment #8481957 -
Attachment is obsolete: true
Attachment #8484216 -
Flags: review?(vporof)
|
|
||
Updated•10 years ago
|
Attachment #8484216 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•