1060840 - Closing a tab with an open toolbox seems to leak its frames

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Looking at bug 1000311, bug 1060836, bug 1060837 there seems to be a general problem with closing a tab with the toolbox open.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Those aren't real leaks but are caused by the fact that destroying a toolbox is async.

Comment 2

[Girish Sharma [:Optimizer]]

forceGC at end of test ?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Not quite as easy :) We force CC/GC multiple times before checking.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-1060840-Make-the-shutdown-leak-detector-wait-unt.patch

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Here's a try run with --per-dir:

https://tbpl.mozilla.org/?tree=Try&rev=c4864714cb1a

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8481957 [details] [diff] [review]
0002-Bug-1060840-Make-the-shutdown-leak-detector-wait-unt.patch

Review of attachment 8481957 [details] [diff] [review]:
-----------------------------------------------------------------

Pretty.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-1060840-Make-the-shutdown-leak-detector-wait-unt.patch, v2

The API changed a little but we're basically doing the same.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/71e13eb13c9b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71e13eb13c9b