Closed Bug 1060944 Opened 10 years ago Closed 10 years ago

Missing inverted panel help icon on Yosemite

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 35
Iteration:
35.1
Tracking Flags:
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 --- verified
firefox35 --- verified

People

(Reporter: ntim, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

fix up help icon on Yosemite,
23.39 KB, patch
ttaubert
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This file ([0]) misses an white icon for the subview open state.

[0] https://hg.mozilla.org/mozilla-central/raw-file/c98e45bed5e0/browser/themes/osx/menuPanel-help-yosemite.png
Flags: needinfo?(gijskruitbosch+bugs)
Marco, can you add this to the upcoming iteration as well, please? :-)
Assignee: nobody → gijskruitbosch+bugs
Blocks: theme-yosemite
Status: NEW → ASSIGNED
Iteration: --- → 35.1
Points: --- → 1
Flags: qe-verify+
Flags: needinfo?(mmucci)
Flags: needinfo?(gijskruitbosch+bugs)
Flags: firefox-backlog+
Added to IT 35.1
Flags: needinfo?(mmucci)
Took the opportunity to better compress some of the other images, too. If you don't have yosemite installed, you can verify this works by changing the 10.10 comparisons in browser/themes/osx/jar.mn to match on your version of OS X.
Attachment #8482273 - Flags: review?(ttaubert)
Comment on attachment 8482273 [details] [diff] [review]
fix up help icon on Yosemite,

Review of attachment 8482273 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8482273 - Flags: review?(ttaubert) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/2878741c88e6
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2878741c88e6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Comment on attachment 8482273 [details] [diff] [review]
fix up help icon on Yosemite,

Approval Request Comment
[Feature/regressing bug #]: bug 1050809
[User impact if declined]: help icon disappears if clicking it in the panel menu
[Describe test coverage new/current, TBPL]: css/icon issue only, so no automated coverage :-(
[Risks and why]: low
[String/UUID change made/needed]: none
Attachment #8482273 - Flags: approval-mozilla-aurora?
QA Contact: catalin.varga
Verified as fixed on:

FF35.0a1
Build Id: 20140909030207
OS: Mac Os X 10.10 DP7
status-firefox35: fixed → verified
Comment on attachment 8482273 [details] [diff] [review]
fix up help icon on Yosemite,

Aurora+
Attachment #8482273 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using:

FF34
Build Id:20140916004001
OS: Mac Os X 10.10
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: