1060960 - Fix D2D 1.1 backend's ClearRect implementation

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Fix D2D 1.1 ClearRect to deal with transforms and complex clips

Right now ClearRect on D2D 1.1 does not correctly support transforms or complex clips. This patch fixes that, notice the complex clip implementation is a not more elegant than it was for D2D 1.0, since we can use DESTINATION_OUT now.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8481968 [details] [diff] [review]
Fix D2D 1.1 ClearRect to deal with transforms and complex clips

Review of attachment 8481968 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetD2D1.cpp
@@ +893,5 @@
> +  if (!mPushedClips.size()) {
> +    return false;
> +  }
> +
> +  std::vector<DrawTargetD2D1::PushedClip>::iterator iter = mPushedClips.begin();

auto iter

@@ +898,5 @@
> +  if (iter->mPath) {
> +    return false;
> +  }
> +  aClipRect = iter->mBounds;
> +  aIsPixelAligned = iter->mIsPixelAligned;

You could fold this into into the loop below by initializing aClipRect to (0,0), mSize

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3706401f8cc9