Closed
Bug 1061011
Opened 11 years ago
Closed 11 years ago
Do not package .mkdir.done in XPIs
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(seamonkey2.29 affected, seamonkey2.30 affected, seamonkey2.31 affected)
RESOLVED
FIXED
seamonkey2.32
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(2 files)
|
711 bytes,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
|
1.02 KB,
patch
|
Callek
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
At the moment .mkdir.done files get packaged along with everything else into XPIs, we should not be doing that.
Attachment #8482017 -
Flags: review?(bugspam.Callek)
status-seamonkey2.29:
--- → affected
status-seamonkey2.30:
--- → affected
status-seamonkey2.31:
--- → affected
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #8482018 -
Flags: review?(bugspam.Callek)
Attachment #8482018 -
Flags: approval-comm-beta?
Attachment #8482018 -
Flags: approval-comm-aurora?
Blocks: DOMi2.0.15
Comment 2•11 years ago
|
||
(In reply to Ian Neal from comment #1)
> Created attachment 8482018 [details] [diff] [review]
> Exclude .mkdir.done files for branches
This is not necessary for branches. Since it doesn't affect any functionality. Just let it ride the trains.
Updated•11 years ago
|
Attachment #8482017 -
Flags: review?(bugspam.Callek) → review+
Comment 3•11 years ago
|
||
Comment on attachment 8482018 [details] [diff] [review]
Exclude .mkdir.done files for branches
Review of attachment 8482018 [details] [diff] [review]:
-----------------------------------------------------------------
a+ for branches, but I agree its not *needed* but I also agree it won't hurt.
Attachment #8482018 -
Flags: review?(bugspam.Callek)
Attachment #8482018 -
Flags: review+
Attachment #8482018 -
Flags: approval-comm-beta?
Attachment #8482018 -
Flags: approval-comm-beta+
Attachment #8482018 -
Flags: approval-comm-aurora?
Attachment #8482018 -
Flags: approval-comm-aurora+
Comment on attachment 8482017 [details] [diff] [review]
Exclude .mkdir.done files [Checked in: Comment 4]
http://hg.mozilla.org/comm-central/rev/07b5639ec5b9
Attachment #8482017 -
Attachment description: Exclude .mkdir.done files → Exclude .mkdir.done files [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.32
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•