957149 - (DOMi2.0.15) DOM Inspector 2.0.15

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Philip Chee]

Build and release a new version of DOMi (2.0.15) to pick up the latest changes:
Bug 867540 - Search by attribute treats missing attribute as the string "null"
Bug 865008 - Search by "ID" never finds any results
Bug 868170 - function DVr_ShowNodeInTree does not always return a value
Bug 868175 - Warning: octal literals and octal escape sequences are deprecated
Bug 833164 - xpcom accessible events (part2 - fix DOMi to pick up interface changes)
Also pick up latest L10n changes.

Comment 1

[Frank Wein [:mcsmurf]]

Colby: AFAIK you're not DOMI owner/peer anymore, but we need your help here :) did you create the DOMI releases for addons.mozilla.org in the past? We want to release a new version, but somehow we have little to no idea about how to create a DOMI release. Do you have an instruction list or similar what's needed a create a new release?

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

I wrote out the process a while ago:
https://wiki.mozilla.org/DOM_Inspector/Releases/Checklist

Note that the build steps won't work with mozilla-central anymore (last time I checked); bug 898945.  You should be able to use 20.0.1, though.

Comment 3

[Tony Mechelynck [:tonymec]. (NEEDINFO me if you want my attention)]

For any Firefox or Thunderbird users getting ants in the legs for lack of a suitable DOMi version, I have uploaded, as attachment 8379295 [details], the version of DOMi 2.0.15pre which was shipped with the SeaMonkey trunk nightly build of 2014-02-14. NO WARRANTY about FITNESS for ANY particular PURPOSE including MERCHANTABILITY. ;-)

Comment 4

[:Gijs (he/him)]

What's needed to get this moving?

Comment 5

[Philip Chee]

(In reply to :Gijs Kruitbosch from comment #4)
> What's needed to get this moving?

q.v. https://wiki.mozilla.org/DOM_Inspector/Releases/Checklist
Someone needs to tag and build a new DOMi. I have the AMO password so once built I'll upload it to AMO

Comment 6

[Ian Neal]

Attachment: DOM Inspector 2.0.15 XPI

Patches included:
https://bugzilla.mozilla.org/showdependencytree.cgi?id=957149&maxdepth=1&hide_resolved=0

Comment 7

[Philip Chee]

Comment on attachment 8460526 [details]
DOM Inspector 2.0.15 XPI

> chrome.manifest
> content inspector chrome/inspector/content/inspector/ xpcnativewrappers=no 
Why aren't we picking up bug 996074. Remove xpcnativewrappers=no directive from DOMi ?

> .mkdir.done
We shouldn't package build system garbage

[not part of the review]
> locale inspector en-US chrome/inspector/locale/en-US/inspector/
[comment: we should flatten this to something like chrome/locale/en-US/ but that's for another bug]
[comment: we should move L10n to babelzilla to fix all the incomplete translations in the DOMi tree]

Comment 8

[Philip Chee]

>> chrome.manifest
>> content inspector chrome/inspector/content/inspector/ xpcnativewrappers=no 
> Why aren't we picking up bug 996074. Remove xpcnativewrappers=no directive
> from DOMi ?

In fact we are. Picking up both the old line and the new one?
Em, CLOBBERing the inspector files in the obj-dir fixes this.

Comment 9

[Ian Neal]

(In reply to Philip Chee from comment #7)
> Comment on attachment 8460526 [details]
> DOM Inspector 2.0.15 XPI
> 
> > .mkdir.done
> We shouldn't package build system garbage
> 
Logged as bug 1061011

Comment 10

[Frank Wein [:mcsmurf]]

Bug 1061011 is fixed, so I guess a new DOMi XPI package could be generated?

Comment 11

[George Malamas]

Hi all, 

In my attachment there is the Greek package of DOMi v2.0.15. 
I'm not sure if this is the right place for translation submissions 
but i don't know which is the official way to localize this project. 
The package i submit is fully localized to Greek and tested by me only. 

This package contains a small modification: 
In styleRules.xul line 65, i have added access key in the label "Toggle !important". 
I have added also the corresponding entities in el and en-US locales 
(file styleRules.dtd line 14). 
I did it just because all other menu items in this menu have access keys.

Comment 12

[George Malamas]

Attachment: Greek localization for DOMi

Comment 13

[:Gijs (he/him)]

Ian, what can we do to resolve this and get (a) the right version of this stuff on AMO, and (b) incorporate the greek translation work?

Comment 14

[Javier "Darth"]

I've submitted bug 1102179 about another issue with element blinking, for you to consider.
Thank you!

Comment 15

[Philip Chee]

Progress to date.
1. Adrian Kalla landed his pl spelling corrections on an old branch. I've grafted the two changesets to both default and to the DOMI_2_0_15 branch.
2. I've closed two heads which were the results of earlier abortive attempts at a 2.0.15 release.
3. Updated the max compat version numbers based on:
https://addons.mozilla.org/en-US/seamonkey/pages/appversions/
4. Bug 1110065 - Pale Moon support for DOMi. Landed on default and DOMI_2_0_15 branch
5. Move the following tags: DOMI_2_0_15_RELEASE and DOMI_LATEST_RELEASE to account for points (1) (3) and (4).
6. Built DOMi 2.0.15. Checked that it worked on Firefox and SeaMonkey.
7. Prepared the release notes
-----------------------------
ToDo: Upload to AMO and followup.

Comment 16

[Philip Chee]

Attachment: Changelog for AMO

Uploaded to AMO @ Saturday 13th December 2014

Comment 17

[Philip Chee]

Update DOM Inspector tag to 'DOMI_LATEST_RELEASE' (2.0.15) for uplift
http://hg.mozilla.org/comm-central/rev/66ba6c033422

Comment 18

[Philip Chee]

DOM Inspector 2.0.15 fully reviewed on addons.mozilla.org

Comment 19

[George Malamas]

Philip, DOMi 2.0.15 currently published on AMO does not include the greek translation, 
i had submitted in time here. 
Is there any problem with the translation?

Comment 20

[Philip Chee]

(In reply to George Malamas from comment #19)
> Philip, DOMi 2.0.15 currently published on AMO does not include the greek
> translation, 
> i had submitted in time here. 
Please in future file a separate bug for your translation (one bug per issue).

> Is there any problem with the translation?
Not that I know. IanN stopped work on DOMi 2.0.15 due to other priorities and I had to pick it up at the last minute. This was the first time for both of us managing a DOMi release and your translation and a few things fell between the cracks. Sorry about that.