1061068 - [Contacts] ICE missing from top of the list when toggling the 'Order by last name'

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. Have some contact entries in Contacts.
2. Set ICE contact and the ICE contact should appears on top of the list.
3. Tap 'Order by last name' from Settings.
4. Back to list

### Actual
ICE is missing from list

### Version
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Broken functionality

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 23633

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

r+ and merged at af04d8bc2111d4ea146239a89ff602206b85eaf5

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

major issue to new feature

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Link to demo

Comment 6

[Loli (:lolimartinezcr)]

Not working in 2.1
Gecko: 06f3a69
Gaia: 47939f4

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Is not working in 2.1 cause it's not been uplifted, can yo confirm in 2.2?

Comment 8

[Loli (:lolimartinezcr)]

Tested and working 
2.2
Flame
Gecko: cce3dff
Gaia: 879bd62

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this when you get a chance.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482737 [details] [review]
Pointer to PR 23633

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Feature ICE Contacts
[User impact] if declined:
Bad user experience, list of ice contacts will dissapear and until we relaunch the app wont be visible
[Testing completed]:
Verified in 2.2
[Risk to taking this patch] (and alternatives if risky):
Pretty low risk patch
[String changes made]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0f39951798192c928fc39a7c71af7f6241a11099

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
2.1
Gecko-bdd77c4
Gaia-b3f9b97

Comment 13

[Roland Kunkel [:RolandK]]

Verified as fixed for the latest 2.1 and 2.2 Flame builds:

Environmental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

'ICE Contacts' appear at the top of the contacts page when order is set to last name.