1061069 - [Contacts] ICE icon on top of the contact list is truncated

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-01-13-09-32.png

### STR
1. Have some contact entries in Contacts.
2. Set ICE contact and the ICE contact should appears on top of the list.

### Actual
ICE icon on top of the contact list is truncated

### Version
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Icon not completely shown, unable to understand what icon that is

Comment 2

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hei Paco,

great, working perfectly!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/1b70a02085432cb4df4e8c943d188b594d68a395

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Will ask for gaia approval once we get the 2.1+

Paco, in the meantime, could you upload a screenshot of the result for drivers to see the difference?

Comment 6

[Paco Rampas [:paco]]

Attachment: ICE-icon-truncate.png

The screenshot. Thanks :D

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Paco!

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

very obvious UI defect on new feature

Comment 9

[Loli (:lolimartinezcr)]

Tested and *not* working. I can see  2014-09-01-13-09-32.png 

Gecko: 06f3a69
Gaia: 47939f4

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Hi Loli,

did you try in 2.2 or 2.1?

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Actually, I've just realised this one wasn't asked to be uplifted.

Will ask for 2.1 approval, once is verified in 2.2

Thanks!

Comment 12

[Loli (:lolimartinezcr)]

Tested amd working
2.2
Flame
User
Gecko: cce3dff
Gaia: 879bd62

Pending 2.1

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483315 [details]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
ICE contacts feature
[User impact] if declined:
Bad user experience
[Testing completed]:
Verified by QA in 2.2
[Risk to taking this patch] (and alternatives if risky):
0, just a minimun css change
[String changes made]:

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/62e324b4ff0ccc1c9012a9f4414188c0816ae274

Comment 15

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
User
Gecko-bdd77c4
Gaia-b3f9b97

Comment 16

[Roland Kunkel [:RolandK]]

This issue is verified fixed for the latest 2.1 and 2.2 Flame builds:

Environmental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The ICE contact icon shows up as expected without truncation.