1061662 - [Meta][Contacts] Visual tweaks in contacts form

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

On flame, build contacts, with pixel ratio 1.5

GAIA_DEV_PIXELS_PER_PX=1.5 make reset-gaia

Several images are not working well

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:Nominating since is a terrible user experience, with broken images

Comment 2

[Anthony Ricaud (:rik)]

I've seen the ICE contact logo on top of the contact list and the new close arrow button in the contact form (creation/edit)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We already had opened 2 bugs to track this, so will put this those two as dependencies for fixing this.

Comment 5

[Maria Angeles Oteo (:oteo)]

what about the favorite icon in the contact list? I think there is not a bug for it, isn't there? Let me know and I can create it.

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issues in new features. obvious UI flaw.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Maria Angeles Oteo (:oteo) from comment #5)
> what about the favorite icon in the contact list? I think there is not a bug
> for it, isn't there? Let me know and I can create it.

We didn't modified the favorite icon, if that one is not ok, then is not a regression, but happy to fix it.

Comment 10

[Anthony Ricaud (:rik)]

Let's not do a regression-window, it's a very easy bug to fix.

Comment 11

[Maria Angeles Oteo (:oteo)]

(In reply to Francisco Jordano [:arcturus] [:francisco] (on PTO till 7th September) from comment #9)
> (In reply to Maria Angeles Oteo (:oteo) from comment #5)
> > what about the favorite icon in the contact list? I think there is not a bug
> > for it, isn't there? Let me know and I can create it.
> 
> We didn't modified the favorite icon, if that one is not ok, then is not a
> regression, but happy to fix it.

It seems that all bugs related to this issue have been closed as duplicated of this meta... so I'm afraid to open a specific bug for it ;) 
I am including a screenshot of the favorite broken icon that Loli captured https://bug1062194.bugzilla.mozilla.org/attachment.cgi?id=8483362, and leave you the choice of creating or not a bug for it.
Thanks Francisco!!

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Not all bugs have been fixed, we still have open bug 1061504.

The favorites icon is not an image problem, but a problem on the list layout, see bug 1062189.

Comment 16

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 17

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

this is the meta for tracking, so it doesn't need to block.

Comment 18

[Jason Smith [:jsmith]]

Francisco - Should any of the dupes be reopened here and tracked under this meta bug? Just want to double check that we aren't letting any bugs fall through the cracks here now that this has become a meta bug.

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Hi Jason, sounds good to me

Comment 20

[Adrián de la Rosa]

If this is just a meta and every related bug is already fixed, should we mark this as resolved?

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

Hi Adrian, you are right, thanks for noticing!