1061140 - [Calendar]Offline calendar in calendar list will change to English when we disable offline calendar.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[swathiks115]

Precondition: Language other than English is selected during boot time[Eg:Bengali]

STR:
1. Open calendar.
2. Disable offline calendar.
3. This will change the offline calendar string to English in calendar list.

Comment 1

[Miller Medeiros [:millermedeiros]]

I can confirm that this bug exists on master, but the calendar app always had this problem (before 2.0 the offline calendar wasn't even localized at first view).

it is caused by the `_update` method on the Settings view: https://github.com/mozilla-b2g/gaia/blame/f04f00605e6edb72ddd9dbb27eac80cb3e259f5d/apps/calendar/js/views/settings.js#L200

going to try to provide a patch for it this week (since it's an easy fix and bad UX).

Comment 2

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23643

fixed the bug and added an unit test that should catch regressions.

Comment 3

[Wayne Chang [:wchang]]

Hi Miller,

Will any additional l10n strings be required or does this reuse the online calendar tags 100%?

Comment 4

[Miller Medeiros [:millermedeiros]]

Hi Wayne, there are no string changes, only JavaScript.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8482957 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23643

LGTM!

Comment 6

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/3d03a2fde2f958a1e5af2ef303d675e537261c5b

Comment 7

[Edward Chen[:edchen]]

[Environment]
Gaia      855be6ade407c26e0596e7306a44deebc3f60933
Gecko     https://hg.mozilla.org/mozilla-central/rev/02c3915bf742
BuildID   20140915160203
Version   35.0a1
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110

[Result]
PASS

Comment 8

[Corinne Innes [:CorinneI]]

Issue still occurs on: 

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022001201
Gaia: 3d9cc667f4e929861a9a77c41096bbf5a9c1bde0
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro Steps:
1) Open Calendar App
2) Return to the homescreen
3) Open Settings>Language
4) Change to a different language
5) Return to the homescreen
6) Open Calendar>offline calendar
7) Enable/disable offline Calendar

Comment 9

[Corinne Innes [:CorinneI]]

Verified fixed on 2.2

Flame 2.2

Environmental Variables:
Device: Flame 2.2 Master(319mb)(KitKat Base)(FullFlash)
Build ID: 20141024040202
Gaia: d893a9b971a0f3ee48e5a57dca516837d92cf52b
Gecko: a5ee2769eb27
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Actual: 
Offline calendar will update to any language and not default to English.

Comment 10

[Shally Li（leave from Mozilla）]

Per Comment 9,clear "verifyme".

Comment 11

[Shally Li（leave from Mozilla）]

Waiting for this bug fixed on Flame v2.0&2.1.