875667 - [Buri][fugu][Calendar]The translation is abnormal after change language and restart.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #457961 +++
 
 Created an attachment (id=416737)
 Snapshot
 
 DEFECT DESCRIPTION:
 
  The translation is abnormal after change language and restart.
 
  REPRODUCING PROCEDURES:
 
  1.DT perso:change system language from English to Polish->calendar->click drawer icon->display in Polish->restart MS->calendar->click drawer icon->display in English==>KO1
  2.TEF perso:change system language from Spanish to English->calendar->click drawer icon->display in English->restart MS->calendar->click drawer icon->display in Spanish==>KO2
 
  EXPECTED BEHAVIOUR:
  KO1==>Should display in Polish.
  KO2==>Should display in English.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:SW12C+DT/TEF
 
  USER IMPACT:Medium
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #457961 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: Snapshot

Clone from brother

Comment 3

[Jason Smith [:jsmith]]

I thought there was a bug on this, apparently not.

Comment 4

[sync-1]

yes, I have checked code..
 
 in calendar/js/templates/calendar.js
 
 (function(window) {
 
   var Cal = Calendar.Template.create({
     item: function() {
       var id = this.h('_id');
       var l10n = '';
 
       // hack localize the only default calendar
       if (id && Calendar.Provider.Local.calendarId === id) {
         // localize the default calendar name
         l10n = 'data-l10n-id="calendar-local"';
       }
       return '<li id="calendar-' + id + '">' +
           '<div class="calendar-id-' + id + ' calendar-color"></div>' +
           '<label>' +
             '<span ' + l10n + ' class="name">' + this.h('name') + '</span>' +
             '<input ' +
               'value="' + id + '" ' +
               'type="checkbox" ' +
               this.bool('localDisplayed', 'checked') + ' />' +
             '<span></span>' +
           '</label>' +
         '</li>';
     }
   });
 
 
 I don't know why add this hack...
 
 This bug mainly caused by above "if"..

Comment 5

[Jack Liu]

Please fix it in v1.1 per comment#4.

Comment 6

[Dylan Oliver [:doliver]]

triage: not blocking for 1.1, will nominate and consider for 1.2

Comment 7

[Dylan Oliver [:doliver]]

triage: moving to consideration for 1.3

Comment 8

[Dylan Oliver [:doliver]]

triage: not blocking, backlogged for 1.3

Comment 9

[Jesse]

Attachment: calendar_l10n.patch

Maybe We need a manual translation here? See the patch.

Comment 10

[Evelyn Hung]

Comment on attachment 8341573 [details] [diff] [review]
calendar_l10n.patch

Evan, can you check out this patch and give some feedback?

Comment 11

[Steven Yang [:styang]]

After discussed with our partner, it will not block fugu.

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8341573 [details] [diff] [review]
calendar_l10n.patch

Let us fix the bug once it has a project flag, or we have time for this bug.

Comment 13

[James Zhang (Spreadtrum)]

Can you fix it on v1.3?

Comment 14

[Miller Medeiros [:millermedeiros]]

looks like this problem was fixed since 2.0, and we will also solve another problem related to the "offline calendar" for 2.2 on Bug 1061140. so I'm marking it as resolved.