Polish search results in sidebar

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
Search
P2
enhancement
VERIFIED FIXED
16 years ago
4 years ago

People

(Reporter: Samir Gehani, Assigned: Samir Gehani)

Tracking

Trunk
mozilla1.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ready to checkin])

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
1. Splitting list to show limited number and inserting "prev" and "next" .
2. Making items more distinct from each other: adding more vertical space
between results?

Matt, Marlon,
Feel free to add other items that need to be done for this feature.
(Assignee)

Updated

16 years ago
Blocks: 102472
(Assignee)

Comment 1

16 years ago
Taking for mozilla0.9.7.
Assignee: matt → sgehani
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7

Comment 2

16 years ago
Another thing we need to do here is to crop the link underline (that appears
when mousing over results) so that it is only as long as the text, not as wide
as the sidebar regardless as it is now.  I think this bug also affects the WR
panel, but that is of a lower priority to fix.

Comment 3

16 years ago
Would it also be possible to make the mouseover cursor a hand rather than an
arrow? I mean, they're links after all.
(Assignee)

Comment 4

16 years ago
Alex,
Yes, that is possible and I'll do it too when I get to this bug.
(Assignee)

Comment 5

16 years ago
-> mozilla0.9.8
Target Milestone: mozilla0.9.7 → mozilla0.9.8
(Assignee)

Comment 6

16 years ago
Here is a more comprehensive list of polish items in the search tab:
    * search results navigation
    * results should behave like links:
          * blue underline
          * red on active
          * purple on visited
          * mouseover cursor should be hand
          * underline only title length
    * icon atop results and search engine name (when in basic mode)
    * description in tooltips
    * remove "bookmark this search"
    * wrapped result titles
    * bulleted results vs. icons (when in basic mode)
Status: NEW → ASSIGNED

Comment 7

16 years ago
what are the chances this will make 098?
(Assignee)

Updated

16 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Assignee)

Updated

16 years ago
Blocks: 93624
(Assignee)

Comment 8

16 years ago
Search triage team: nsbeta1+
Keywords: nsbeta1+
(Assignee)

Comment 9

16 years ago
We are not doing the following:
 * icon atop results and search engine name (when in basic mode)
   Why not?  Because the engine name is in the menulist and it appears redundant.

 * description in tooltips
   Why not?  Not part of Sherlock spec.  We aren't extending Sherlock this time.

 * wrapped result titles
   Why not?  Looks ugly, needs time we don't have right now, and tooltips
   suffice.

 * bulleted results vs. icons (when in basic mode)
   Why not?  Because the engine icons are needed for mixed results in 
   Advanced mode.  And because doing special stuff to swap the icon after 
   the results have loaded for either mode means a performance hit.
Target Milestone: mozilla0.9.9 → mozilla1.0
(Assignee)

Comment 10

16 years ago
Note, we have included drag support so links can now be dragged from the search
results tab to the content area to load a URL or to the URL or for pasting into
the editor or a textfield.
(Assignee)

Comment 11

16 years ago
Created attachment 71816 [details] [diff] [review]
Patch for listed items here.  

This patch also covers:
bug 93624:  visited links in the search tab do not change color
bug 118030: Move search item to bottom of context menu per spec
bug 114972: Search context menu item should be visible but disabled even when 
	    text not selected

All 3 bugs are nsbeta1+.
(Assignee)

Updated

16 years ago
Blocks: 114972
(Assignee)

Updated

16 years ago
Blocks: 118030
(Assignee)

Comment 12

16 years ago
morse, please r.
hewitt, please sr.

Thanks.
(Assignee)

Updated

16 years ago
Keywords: patch, review

Comment 13

16 years ago
Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

r=morse
Attachment #71816 - Flags: review+

Comment 14

16 years ago
Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

sr=hewitt
Attachment #71816 - Flags: superreview+
(Assignee)

Updated

16 years ago
Keywords: review
Whiteboard: [ready to checkin]

Comment 15

16 years ago
Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #71816 - Flags: approval+
(Assignee)

Comment 16

16 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 17

16 years ago
VERIFIED Fixed with 20020322 builds
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.