1061337 - Error when bookmarking a URL from Twitter

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Richard Newman [:rnewman]]

Doesn't have a title, so:

java.lang.IllegalArgumentException: the bind value at index 1 is null
	at android.database.sqlite.SQLiteProgram.bindString(SQLiteProgram.java:164)
	at android.database.sqlite.SQLiteProgram.bindAllArgsAsStrings(SQLiteProgram.java:200)
	at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:68)
	at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1370)
	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:421)
	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:354)
	at org.mozilla.gecko.db.BrowserProvider.query(BrowserProvider.java:851)
	at android.content.ContentProvider.query(ContentProvider.java:869)
	at android.content.ContentProvider$Transport.query(ContentProvider.java:212)
	at android.content.ContentResolver.query(ContentResolver.java:476)
	at android.content.ContentResolver.query(ContentResolver.java:419)
	at org.mozilla.gecko.db.LocalBrowserDB.addBookmark(LocalBrowserDB.java:1005)
	at org.mozilla.gecko.overlays.service.sharemethods.AddBookmark.handle(AddBookmark.java:22)
	at org.mozilla.gecko.overlays.service.OverlayActionService$1.run(OverlayActionService.java:118)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:157)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Don't try to bind a null title. v1

Comment 2

[Chris Kitching [:ckitching]]

Comment on attachment 8482438 [details] [diff] [review]
Don't try to bind a null title. v1

Review of attachment 8482438 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good,  but ill look strange in ui. just the small text for he url and nothing else.

Comment 3

[Richard Newman [:rnewman]]

Yup, nothing we can do about that yet. All this does is stop us crashing on insert!

Comment 4

[Chris Kitching [:ckitching]]

String process he url to try and et something usable s a provisional title?
Change the way we sh ow bookmarks in this case?

Eventually i guess we wan theaddless gecko to fetch it for us.

Also, my phone keYboard freezes for ten seconds at random intervals while i type o bugzilla.... Firefox bug methinks?

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/851cc4154553

Comment 6

[Richard Newman [:rnewman]]

(In reply to Chris Kitching [:ckitching] from comment #4)
> String process he url to try and et something usable s a provisional title?
> Change the way we sh ow bookmarks in this case?

We should be able to show a title-less bookmark reasonably well.

> Eventually i guess we wan theaddless gecko to fetch it for us.

Yes.


> Also, my phone keYboard freezes for ten seconds at random intervals while i
> type o bugzilla.... Firefox bug methinks?

File it... when you're back at a keyboard!

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/851cc4154553