Closed
Bug 1061388
Opened 10 years ago
Closed 10 years ago
subconfigure.py should not rely on shebang for invoking config.status
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1052560
People
(Reporter: m1, Assigned: m1)
References
Details
Attachments
(1 file)
1.02 KB,
patch
|
glandium
:
review-
|
Details | Diff | Splinter Review |
Given a very deep build root directory, build/autoconf/config.status.m4 will construct a #! for config.status that exceeds the ~128 character limit for the path to the python interpreter on some systems (eg. Linux).
This causes a failed build with an error similar to
---
...
checking for posix_fadvise... no
checking for posix_fallocate... no
checking for setlocale... yes
checking for localeconv... (cached) no
updating cache /local/mnt/workspace/lnxbuild/project/trees_in_use/free_tree_b2g_manifest_b2g_toaster_grease_commander_4330630/checkout/out/target/product/toaster/obj/objdir-gecko/config.cache
creating ./config.status
/bin/sh: ./config.status: /local/mnt/workspace/lnxbuild/project/trees_in_use/free_tree_b2g_manifest_b2g_: bad interpreter: No such file or directory
*** Fix above errors and then restart with\
"make -f client.mk build"
make[3]: *** [configure] Error 1
---
Other places in the build system seem to always take care to explicitly invoke |$PYTHON ./config.status| to avoid this problem.
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8482484 [details] [diff] [review]
+ $PYTHON
Review of attachment 8482484 [details] [diff] [review]:
-----------------------------------------------------------------
Not all config.statuses subconfigure.py invokes are python scripts.
Attachment #8482484 -
Flags: review?(mh+mozilla) → review-
Comment 3•10 years ago
|
||
Also, there's already a bug on file on that issue... if I can find it.
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•