Closed Bug 1061388 Opened 10 years ago Closed 10 years ago

subconfigure.py should not rely on shebang for invoking config.status

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1052560

People

(Reporter: m1, Assigned: m1)

References

Details

Attachments

(1 file)

Given a very deep build root directory, build/autoconf/config.status.m4 will construct a #! for config.status that exceeds the ~128 character limit for the path to the python interpreter on some systems (eg. Linux). This causes a failed build with an error similar to --- ... checking for posix_fadvise... no checking for posix_fallocate... no checking for setlocale... yes checking for localeconv... (cached) no updating cache /local/mnt/workspace/lnxbuild/project/trees_in_use/free_tree_b2g_manifest_b2g_toaster_grease_commander_4330630/checkout/out/target/product/toaster/obj/objdir-gecko/config.cache creating ./config.status /bin/sh: ./config.status: /local/mnt/workspace/lnxbuild/project/trees_in_use/free_tree_b2g_manifest_b2g_: bad interpreter: No such file or directory *** Fix above errors and then restart with\ "make -f client.mk build" make[3]: *** [configure] Error 1 --- Other places in the build system seem to always take care to explicitly invoke |$PYTHON ./config.status| to avoid this problem.
Attached patch + $PYTHONSplinter Review
Assignee: nobody → mvines
Status: NEW → ASSIGNED
Attachment #8482484 - Flags: review?(mh+mozilla)
Comment on attachment 8482484 [details] [diff] [review] + $PYTHON Review of attachment 8482484 [details] [diff] [review]: ----------------------------------------------------------------- Not all config.statuses subconfigure.py invokes are python scripts.
Attachment #8482484 - Flags: review?(mh+mozilla) → review-
Also, there's already a bug on file on that issue... if I can find it.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: