1052560 - Shell doesn't run scripts with a very long #! interpreter

Status: NEW

(Firefox Build System :: General, defect)

Description

[Oleksiy Avramchenko]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140715215003

Steps to reproduce:

Running config.status scripts from subconfigure.py via shell -c won't work for the python scripts with very long #! interpteter name, causing FXOS gecko build to fail. Seems to start after bug #1046533 merge. This happens on Ubuntu 12.04 and most likely bash is to blaim.

It's hidden on normal runs when source tree is located close to the /, but our build servers got affected where tree is checked out into the quite long directory name where final #! /*/_virtualenv/bin/python is like 170 chars long.

For the local quick fix we changed the subconfigure.py to read the first line of the script and use the specified interpreter instead of data['shell'] -c.

Comment 1

[Oleksiy Avramchenko]

Attachment: 0001-Call-exact-interpreter-for-the-config.status.patch

Sample patch of the quick local workaround.

Comment 2

[Loic]

CC for review.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8471701 [details] [diff] [review]
0001-Call-exact-interpreter-for-the-config.status.patch

Review of attachment 8471701 [details] [diff] [review]:
-----------------------------------------------------------------

That will break on windows because /bin/sh won't be recognized.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Loic from comment #2)
> CC for review.

Loic, it's the second time you needinfo? me for a review. Please use the review? flag on the patch to review instead.

Comment 5

[Loic]

(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Loic from comment #2)
> > CC for review.
> 
> Loic, it's the second time you needinfo? me for a review. Please use the
> review? flag on the patch to review instead.

Yeah, sorry, I'm not very familiar with reviewing, and as I only sort bugs (so I use needinfo? a lot), I forgot to use the review? flag. :)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:ahochheiden, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.