1061395 - crash in __android_log_assert | stagefright::MPEG4Source::start(stagefright::MetaData*)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Andreas Gal :gal]

This bug was filed from the Socorro interface and is 
report bp-23b3f821-561f-42fe-ab6d-4142c2140902.
=============================================================

Comment 1

[Carsten Book [:Tomcat]]

same crash for me also on spiegel.de :( one of Germany's topsites

Comment 2

[Carsten Book [:Tomcat]]

bisecting showed:

Last good revision: 0753f7b93ab7
First bad revision: b682c9e52fee
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0753f7b93ab7&tochange=b682c9e52fee

Comment 3

[Matthew Gregan [:kinetik]]

Likely bug 1043696, which exposed this code (and enabled native MP4) on OS X.

Comment 4

[Carsten Book [:Tomcat]]

ralph could you take a look here, thanks!

Comment 5

[Ralph Giles (:rillian)]

This one I can reproduce visiting spiegel.de on mid 2011 11-inch MacBook Air running 10.10 beta 1.

It's crashing in one of the CHECK asserts in MPEG4Source::start() so probably a parser problem.

Comment 6

[Dave Townsend [:mossop]]

Also consistently crashes on https://www.flickr.com/create

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

I get this 100% of the time on both Mac OS X 10.10 (Yosemite) and Windows 7 (64-bit) versions of Firefox nightly; here's an incident from Mac OS X: https://crash-stats.mozilla.com/report/index/6ab3c01c-5893-4246-a620-69ab62140909

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Stephen Donner [:stephend] from comment #7)
> I get this 100% of the time on both Mac OS X 10.10 (Yosemite) and Windows 7
> (64-bit) versions of Firefox nightly; here's an incident from Mac OS X:
> https://crash-stats.mozilla.com/report/index/6ab3c01c-5893-4246-a620-
> 69ab62140909

Er, sorry for the spam, and the website that crashes 100% of the time is http://www.webperformance.com/

Comment 9

[Ralph Giles (:rillian)]

Thanks for the better STR. That one even crashes my 10.8.5 MacBook Pro.

Comment 10

[Ralph Giles (:rillian)]

Failing assertion is MPEG4Extractor.cpp:2502

  CHECK(mFormat->findInt32(kKeyMaxInputSize, &max_size));

File is http://www.webperformance.com/load-testing/demo/intro-animation/intro-animation.mp4 and crash happens if I load it directly.

$ mp4info intro-animation.mp4 
mp4info version 2.0.0
intro-animation.mp4:
ReadChildAtoms: "intro-animation.mp4": In mp4a atom, extra 4 bytes at end of atom
ReadChildAtoms: "intro-animation.mp4": In atom mp4a missing child atom esds
ReadAtom: "intro-animation.mp4": atom type  is suspect
ReadAtom: "intro-animation.mp4": invalid atom size, extends outside parent atom - skipping to end of "wave" "" 4304159 vs 706
ReadAtom: "intro-animation.mp4": atom type  is suspect
ReadChildAtoms: "intro-animation.mp4": In atom mp4a missing child atom esds
ReadChildAtoms: "intro-animation.mp4": In avc1 atom, extra 4 bytes at end of atom
Track	Type	Info
1	audio	MPEG-4 AAC LC, 123.040 secs, 60 kbps, 32000 Hz
2	video	H264 Main@3.1, 123.651 secs, 214 kbps, 1080x720 @ 30.303030 fps
ReadChildAtoms: "intro-animation.mp4": In mp4a atom, extra 4 bytes at end of atom
ReadChildAtoms: "intro-animation.mp4": In atom mp4a missing child atom esds
ReadAtom: "intro-animation.mp4": atom type  is suspect
ReadAtom: "intro-animation.mp4": invalid atom size, extends outside parent atom - skipping to end of "wave" "" 4304159 vs 706
ReadAtom: "intro-animation.mp4": atom type  is suspect
ReadChildAtoms: "intro-animation.mp4": In atom mp4a missing child atom esds
ReadChildAtoms: "intro-animation.mp4": In avc1 atom, extra 4 bytes at end of atom

Comment 11

[Ralph Giles (:rillian)]

This key is set when parsing the 'stsz' or 'stz2' atom. The file has one, but we don't read it.

Comment 12

[David Burns :automatedtester]

Instant crash when visiting https://vine.co and the videos start playing

https://crash-stats.mozilla.com/report/index/aecc0178-4991-434d-91a3-868f02140919
https://crash-stats.mozilla.com/report/index/6c7c200b-fed6-47b0-98f0-112832140919
https://crash-stats.mozilla.com/report/index/c5c407ea-47f4-455a-b331-eda3f2140919

Comment 13

[David Burns :automatedtester]

literally can't use vine now in Firefox...

Comment 14

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Keeps happening on http://the-end.nouvelles-ecritures.francetv.fr/

Click on the "Composez votre film" link at the bottom.

Comment 15

[Ralph Giles (:rillian)]

I've been unable to reproduce this locally. The nouvelles-ecritures site is serving me webm now, but vine.co also works fine.

Can you please try again, since this has been a system-dependent issue?

Comment 16

[Ralph Giles (:rillian)]

Closing. Please reopen if you can reproduce.