1061413 - [Contacts] Favorites on top of ICE if ICE set first, and Favorites set later

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-01-18-50-07.png

### STR
1. Set ICE to some contact, make sure it appears on top of contact list.
2. Set a contact to Favorites.

### Actual 
Favorites is on top of ICE.

### Expected
Left of 2014-09-01-18-50-07.png
Page 5 of https://bugzilla.mozilla.org/attachment.cgi?id=8459474
ICE above Favorites


### Version
Gaia      e7d31f0e9b6b19d9b484eeec8fb980718bc40d79
Gecko     https://hg.mozilla.org/mozilla-central/rev/532b5fb77ba1
BuildID   20140901160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-01-18-50-07.jpg

Comment 2

[Eric Chang [:ericcc] [:echang]]

Relaunch Contacts is not reproducible.

Comment 3

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Spec

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 23629

Comment 5

[Eric Chang [:ericcc] [:echang]]

I found that contacts that are added later than setting the ICE are also appears above ICE, not just the Favorites.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issue on new feature

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8482695 [details] [review]
Pointer to PR 23629

Thanks Francisco!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/5730a8531868f0f7b6267a44601d601e8b48560a

Thx!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482695 [details] [review]
Pointer to PR 23629

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Cause by new feature ICE contacts
[User impact] if declined:
Really bad experience and confusing, since icons will swap positions
[Testing completed]:
Manual smoke test
[Risk to taking this patch] (and alternatives if risky):
Not pretty risky
[String changes made]:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/9c6e433e8f9f2f170f8492700ee8cf84c27493cb

Comment 12

[Loli (:lolimartinezcr)]

Tested and now once a contact is marked as favorite, it isn't visible inmediately. User has to close contact application (Close in background) and user has to access to Contacts application. For this reason I can't verified this bug
Flame
2.1
Gecko-64e892b
Gaia-79dc972

Comment 13

[Eric Chang [:ericcc] [:echang]]

I found this recently but not yet submit a bug, modifications to contact entry are not immediately shown, I will also try to find a much more concrete str for filing a bug.
 
(In reply to Loli (:lolimartinezcr) from comment #12)
> Tested and now once a contact is marked as favorite, it isn't visible
> inmediately. User has to close contact application (Close in background) and
> user has to access to Contacts application. For this reason I can't verified
> this bug
> Flame
> 2.1
> Gecko-64e892b
> Gaia-79dc972

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Loli (:lolimartinezcr) from comment #12)
> Tested and now once a contact is marked as favorite, it isn't visible
> inmediately. User has to close contact application (Close in background) and
> user has to access to Contacts application. For this reason I can't verified
> this bug
> Flame
> 2.1
> Gecko-64e892b
> Gaia-79dc972

I think that you are talking about a different bug, bug 1063218 which has been marked as a duplicated of bug 1065005 that we just updated.

Comment 15

[Loli (:lolimartinezcr)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #14)
> (In reply to Loli (:lolimartinezcr) from comment #12)
> > Tested and now once a contact is marked as favorite, it isn't visible
> > inmediately. User has to close contact application (Close in background) and
> > user has to access to Contacts application. For this reason I can't verified
> > this bug
> > Flame
> > 2.1
> > Gecko-64e892b
> > Gaia-79dc972
> 
> I think that you are talking about a different bug, bug 1063218 which has
> been marked as a duplicated of bug 1065005 that we just updated.

Thanks Francisco

Comment 16

[Loli (:lolimartinezcr)]

Tested and working
2.2
Flame
Gecko-eb14ebf
Gaia-7c5014a

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Link to demo

Comment 18

[Robert Mead [:RobertM]]

The ICE symbol will always be at the very top of the contacts list, regardless of when other contacts or favorites were added.

Flame 2.1 (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0