1061441 - [Vertical Home] Long bookmark name appears as partly cut from right side.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Mukesh kumar]

[Long bookmark name appears as partly cut from right side]
Precondition:
1.Install bookmark from collection.
2.Replace name with long text.

STR
=====
1. long press bookmark -> click cross button

Actual: The name appears cut from right side

Expected: The name should show in ellipsis form if text is long

Comment 1

[Mukesh kumar]

Attachment: Bookmark.png

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Screenshot with the patch

Comment 4

[Cristian Rodriguez (:crdlc)]

Actually it happens with apps, collections or bookmarks although it was discovered with bookmarks because they are editable.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8482587 [details]
Github pull request

Seems unlikely that a user will ever see this, but code looks fine to me. Thanks!

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/98fbb734d9b90dd5e1538d29880cfd3b01439937

Comment 7

[Elie]

Attachment: Verify1_Flame 2.2&3.0_N5 2.2&3.0_Pass.png

According to the STR in comment 0, this issue is verified pass on latest flame 2.2&3.0 and N5 2.2&3.0 build, if the name of bookmark is too long to fit in the delete view, it will begin a new line.
See attachment:Verify1_Flame 2.2&3.0_N5 2.2&3.0_Pass.png.
Reproducing rate:0/10

Device:Flame 2.2 build (Pass)
Build ID               20150525162504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/115112d51e08
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.202102
Firmware Date          Mon May 25 20:21:12 EDT 2015
Bootloader             L1TC000118D0

Device:Flame 3.0 build (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.192755
Firmware Date          Mon May 25 19:28:07 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus 5 2.2 build (Pass)
Build ID               20150525002504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.041303
Firmware Date          Mon May 25 04:13:19 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 build (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.192207
Firmware Date          Mon May 25 19:22:24 EDT 2015
Bootloader             HHZ12f