Closed Bug 1061503 Opened 10 years ago Closed 10 years ago

Comments field in contact edit form needs to have the text at the top, and be converted to a textarea

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.1 affected, b2g-v2.2 verified)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.1 --- affected
b2g-v2.2 --- verified

People

(Reporter: sergi, Assigned: sergi)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Github PR
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review 
      No description provided.
Assignee: nobody → sergi.mansilla
Whiteboard: P=2
Target Milestone: --- → 2.1 S4 (12sep)
This is a very simple, low-risk fix that improves user experience a lot.
blocking-b2g: --- → 2.1?
triage: major issue to new feature "contacts form redesign".
Functionality-wise it works properly, but this fix(polish) is must-have to make the feature shiny.
blocking-b2g: 2.1? → 2.1+
Triage group reviewed - polish bugs cannot hold back an entire release from shipping. Please review the blocking criteria at https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines to understand what constitutes a blocker.

2.1 is open for approved landings, so request approval from Fabrice or Bhavana in order to land this if it's fixed in time!
blocking-b2g: 2.1+ → backlog
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
Whiteboard: P=2 → [p=1]
QA Whiteboard: [EditRedesign]
Attached file Github PR — 

        Attachment #8496819 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8496819 [details] [review]
Github PR

Codewise was looking good to me. Until i tried on the phone.

When creating or adding it works perfectly, but when editing acontact that already has a 'note' field, it fills it empty and we lose the info if we save.

Probably in form.js when we are filling the info we have a selector based on 'input' and now we have textarea.

        Attachment #8496819 -
        Flags: review?(francisco) → review-

    
    

    
  
Oops, mea culpa, I only tried the add scenario :(
Target Milestone: 2.1 S5 (26sep) → 2.1 S6 (10oct)

    
    

    
  
Comment on attachment 8496819 [details] [review]
Github PR

Fixed that scenario now.

        Attachment #8496819 -
        Flags: review- → review?(francisco)

    
  
Blocks: 1069288

    
    

    
  
Comment on attachment 8496819 [details] [review]
Github PR

Working perfect, Sergi could you reopen the PR and merge?

Thanks!

        Attachment #8496819 -
        Flags: review?(francisco) → review+

    
    

    
  
Merged at 6e91a0f2decb8d4d6f29d5fbf424181182eb1139.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Per bug 1108494, we forgot to uplift this bug to the 2.1 branch. Can you take a look at it Sergi?

          status-b2g-v2.1:
          --- → affected

          status-b2g-v2.2:
          --- → verified
Flags: needinfo?(sergi.mansilla)
Depends on: 1132251
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

    
    

    
  
Bug has already been closed. Clearing Need-Infos.
Flags: needinfo?(sergi.mansilla)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: