Closed
Bug 1061507
Opened 11 years ago
Closed 11 years ago
Grey layer on contacts edit form when a photo is present
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: sergi, Assigned: sergi)
References
Details
(Whiteboard: P=1)
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
arcturus
:
review+
fang
:
ui-review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
74.24 KB,
image/png
|
Details |
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → sergi.mansilla
Whiteboard: P=1
Target Milestone: --- → 2.1 S4 (12sep)
Assignee | ||
Comment 1•11 years ago
|
||
This is a very simple, low-risk fix that improves user experience a lot.
blocking-b2g: --- → 2.1?
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8482651 -
Flags: review?(francisco)
Assignee | ||
Updated•11 years ago
|
Attachment #8482651 -
Flags: ui-review?(fshih)
Comment 3•11 years ago
|
||
Comment on attachment 8482651 [details] [review]
Github PR
Simple fix, thx Sergi!
Attachment #8482651 -
Flags: review?(francisco) → review+
Comment 4•11 years ago
|
||
Comment on attachment 8482651 [details] [review]
Github PR
looks good, Thanks!
Attachment #8482651 -
Flags: ui-review?(fshih) → ui-review+
Comment 5•11 years ago
|
||
Hey Guys,
After I installed the patch. The photo area looks good, but the Add buttons are incorrect size, they are bigger and half cut off now : (
I am not sure was just for this patch or???
Thanks!
Comment 6•11 years ago
|
||
(In reply to Fang Shih [:fang] from comment #5)
> Created attachment 8483282 [details]
> contact_screenshot.png
>
> Hey Guys,
> After I installed the patch. The photo area looks good, but the Add buttons
> are incorrect size, they are bigger and half cut off now : (
> I am not sure was just for this patch or???
> Thanks!
oops! I meant to say remove button (red button) not the add button. Sorry about that :p
Assignee | ||
Comment 7•11 years ago
|
||
I saw that too, but it is not related to this fix. Will investigate.
Thanks!
Assignee | ||
Comment 8•11 years ago
|
||
Merged at 5cca9c25881a92e2ed700d6a9bae03f6d1e865b7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
(In reply to Sergi Mansilla [:sergi] (Telenor) from comment #7)
> I saw that too, but it is not related to this fix. Will investigate.
>
> Thanks!
Thanks Sergi!
Please let me know if I need to open a bug or any follow ups! : ) Thank you!
Comment 10•11 years ago
|
||
(In reply to Fang Shih [:fang] from comment #9)
> Please let me know if I need to open a bug or any follow ups! : ) Thank you!
Hi Fang, bug 1061662 was opened to handle with these wrong images in Contacts. Hope it helps.
Updated•11 years ago
|
blocking-b2g: 2.1? → backlog
Comment 11•11 years ago
|
||
Comment on attachment 8482651 [details] [review]
Github PR
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression, but a tiny enhancement
[User impact] if declined:
Bad user experience
[Testing completed]:
Being in master for 1 week
[Risk to taking this patch] (and alternatives if risky):
Nothing, removing a css line
[String changes made]:
Attachment #8482651 -
Flags: approval-gaia-v2.1?(fabrice)
Updated•11 years ago
|
Attachment #8482651 -
Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Comment 12•11 years ago
|
||
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•