1061507 - Grey layer on contacts edit form when a photo is present

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This is a very simple, low-risk fix that improves user experience a lot.

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482651 [details] [review]
Github PR

Simple fix, thx Sergi!

Comment 4

[Fang Shih [:fang]]

Comment on attachment 8482651 [details] [review]
Github PR

looks good, Thanks!

Comment 5

[Fang Shih [:fang]]

Attachment: contact_screenshot.png

Hey Guys, 
After I installed the patch. The photo area looks good, but the Add buttons are incorrect size, they are bigger and half cut off now : (
I am not sure was just for this patch or??? 
Thanks!

Comment 6

[Fang Shih [:fang]]

(In reply to Fang Shih [:fang] from comment #5)
> Created attachment 8483282 [details]
> contact_screenshot.png
> 
> Hey Guys, 
> After I installed the patch. The photo area looks good, but the Add buttons
> are incorrect size, they are bigger and half cut off now : (
> I am not sure was just for this patch or??? 
> Thanks!

oops! I meant to say remove button (red button) not the add button. Sorry about that :p

Comment 7

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I saw that too, but it is not related to this fix. Will investigate.

Thanks!

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at 5cca9c25881a92e2ed700d6a9bae03f6d1e865b7

Comment 9

[Fang Shih [:fang]]

(In reply to Sergi Mansilla [:sergi] (Telenor) from comment #7)
> I saw that too, but it is not related to this fix. Will investigate.
> 
> Thanks!

Thanks Sergi! 
Please let me know if I need to open a bug or any follow ups! : ) Thank you!

Comment 10

[Maria Angeles Oteo (:oteo)]

(In reply to Fang Shih [:fang] from comment #9)

> Please let me know if I need to open a bug or any follow ups! : ) Thank you!

Hi Fang, bug 1061662 was opened to handle with these wrong images in Contacts. Hope it helps.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482651 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression, but a tiny enhancement
[User impact] if declined:
Bad user experience
[Testing completed]:
Being in master for 1 week
[Risk to taking this patch] (and alternatives if risky):
Nothing, removing a css line
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6bb21d0e233923f99ac584d6e253a874815db373