1061612 - Move "Exit Guest Mode" menu item to Tools menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gervase Markham [:gerv]]

The Exit Guest Mode menu item should be on the Tools menu, where the "Enter Guest Mode" menu item is/was. See bug 1061263 for some of the problems caused by its current location at the very bottom of the main menu.

This bug depends on us having a persistent notification for guest mode - bug 897711.

Gerv

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Yuan - When we move the menu, do we want to continue using the two different menu text strings? Or do we want to switch to a toggle style menu?

Comment 2

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I suggest we use two different text strings: Enter/Exit Guest Session. I don't think a pure-text toggle can communicate the message clearly.

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: Move guest mode

mxr-ed for guest_session, changed those in all resources, verified on my set of devices.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8510539 [details] [diff] [review]
Patch: Move guest mode

Review of attachment 8510539 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/0e5f72c66f06

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8510539 [details] [diff] [review]
Patch: Move guest mode

Approval Request Comment
[Feature/regressing bug #]: Guest mode system notification obsoletes "ease of leaving guest mode" so the "Exit guest mode" menu item should be moved back to match "Start guest mode"
[User impact if declined]: Location of "Exit guest mode" could be unintuitive to find
[Describe test coverage new/current, TBPL]: local
[Risks and why]: very low, moving layout items around
[String/UUID change made/needed]: none

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e5f72c66f06

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Device: Nexus 5 (Android 4.4)
Build: Firefox for Android 36.0a1 (2014-10-26)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/42d38ca6114d

Comment 10

[Teodora Vermesan (:TeoVermesan)]

"Exit Guest Session" is present in the Tools Menu, so:
Verified fixed on:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 36.0a1 (2014-10-31) and Firefox for Android 35.0a2 (2014-10-31)