1061623 - Write tests for ticker updates on the call screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/pull/23435#discussion-diff-16882245

Looks like we're not testing this since the code change didn't break any test.

Comment 1

[David Garcia [:davidg][retired]]

Please, quick check if we still need more tests but it seems to me that it is covered, mostly because the changes introduced in Bug 106274.

This test should be testing that part:
     test('createTicker should update timer every second', function() {
       this.sinon.spy(Utils, 'prettyDuration');
       this.sinon.clock.tick(1000);
       sinon.assert.calledWith(Utils.prettyDuration, timeNode, 1000);
     });

Comment 2

[Doug Sherk (:drs) (inactive)]

(In reply to David Garcia [:davidg] from comment #1)
> changes introduced in Bug 106274.

David was referring to bug 1062749.

Comment 3

[Doug Sherk (:drs) (inactive)]

Yeah, it looks like our test coverage here is fine now. Thanks for investigating.