Closed
Bug 1061758
Opened 10 years ago
Closed 10 years ago
Mochitest OOP (M-oop) includes the symbol with the number
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
2.24 KB,
patch
|
camd
:
review+
camd
:
review+
|
Details | Diff | Splinter Review |
We need the treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/718d944e6511#l3.13
https://github.com/mozilla/treeherder-service/blob/0ae443a35bf677df829d7a83c79abd5693cc8551/treeherder/etl/buildbot.py#L779
def get_symbol(name, bn):
...
# Mochitests and Mochitest-e10s are the only ones that display
# only as a number, no letters
if s in ["M", "M-e10s"]:
s = ""
Depends on bug 1046743, since without that, we'll have jobs with the name suppressed, but that get no symbol either, so display as the empty string.
Assignee | ||
Updated•10 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8483787 -
Flags: review?(cdawson)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8483787 [details] [diff] [review]
Suppress the job name from Mochitest-OOP symbols too
Adding jeads as a reviewer to spread the load a bit, whichever of you gets to this first can cancel the other person's review.
Attachment #8483787 -
Flags: review?(jeads)
Updated•10 years ago
|
Attachment #8483787 -
Flags: review?(jeads)
Attachment #8483787 -
Flags: review?(cdawson)
Attachment #8483787 -
Flags: review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks :-)
https://github.com/mozilla/treeherder-service/commit/086820ff20955031d1a0a39756691d51e1dccb8b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•