1046743 - Mochitest OOP and multi-part xpcshell jobs are missing the job part number from their symbol

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Nathan Froyd [:froydnj]]

Compare:

https://tbpl.mozilla.org/?tree=Try&rev=117245a61c89

versus:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=117245a61c89

In the TBPL version, the xpcshell jobs on Android 2.3 opt are X1, X2, X3.  On the treeherder version, they are all simply X; it is unclear whether those are distinct jobs or retriggers of the same job.

Comment 1

[William Lachance (:wlach)]

I'll take this one.

Looks like the problem is inside the API, not the frontend:

https://treeherder.mozilla.org/api/project/try/resultset/1/get_resultset_jobs/?format=json&result_set_ids=6444

Jeads recommends investigating the buildbot mappings inside treeherder to fix this, I'll do that:

https://github.com/mozilla/treeherder-service/blob/master/treeherder/etl/buildbot.py#L681

Comment 2

[Ed Morley [:emorley]]

It's due to https://github.com/mozilla/treeherder-service/blob/master/treeherder/etl/buildbot.py#L710

Comment 3

[Ed Morley [:emorley]]

Compare to:
http://hg.mozilla.org/webtools/tbpl/file/9cb4d4589a82/js/Data.js#l878

Which was made generic at some point after treeherder copied the regex, by:
http://hg.mozilla.org/webtools/tbpl/rev/b7a6c5411bd8

Comment 4

[Ed Morley [:emorley]]

(Sorry I had looked briefly at this the other day, had forgotten to comment on the bug. Happy to take this one if you have not started it, since it's the treeherder equivalent of bug 978686 and overlaps with my patches in bug 1040418)

Comment 5

[William Lachance (:wlach)]

GoForIt (tm) :)

Comment 6

[Ed Morley [:emorley]]

This affects Mochitest OOP too.

Comment 7

[Ed Morley [:emorley]]

Attachment: PR#197 - Make the job part number regex more generic

Prior to this patch each new job that was made made-part (eg xpcshell-1, xpcshell-2, ...) would need adding to the regex. Since jobnames were made more consistent, the generic regex doesn't hit false positives, so we can use this instead for reduced maintenance.

Is the treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/b7a6c5411bd8

Comment 8

[Ed Morley [:emorley]]

s/made-part/multi-part/

Comment 9

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-service/commit/bf60d1908e85f925cdf7a7a9b5bdc52082e64bab