1061924 - When finishing FTE, call forwarding icons display briefly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

In bug 1035250, we changed FTE to only build and display call forwarding icons after the FTE is over. Now they flash on screen for a moment, which looks bad.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]: Pretty easy fix, and it looks really unprofessional to have these rarely shown icons display on the screen for a moment.

Comment 2

[Marcia Knous [:marcia]]

Attachment: 2014-09-02-22-56-35.png

Adding this screenshot. During testing of the build after branched, they do eventually go away, but they often do hang around on the homescreen for a while.

Gaia   fbb297c39aab5f17b179533d2a9a6c5166b2c197
SourceStamp fb5e796da813
BuildID 20140902160204
Version 34.0a2
base: v123

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] hide call forwarding at first

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8483912 [details] [review]
[Gaia PR] hide call forwarding at first

r=me

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/5765c62163bcb7fde5ebfd211881117de31a7c46

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8483912 [details] [review]
[Gaia PR] hide call forwarding at first

[Bug caused by] (feature/regressing bug #):
bug 1035250

[User impact] if declined:
bad UX, inappropriate icons display in the statusbar

[Testing completed]:
manually, and unit tests

[Risk to taking this patch] (and alternatives if risky):
call forwarding and signal icons display is changed, but low risk

[String changes made]: none

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b9afbf89c7d1fd59332b202db9f24e8fafb19f8f

Comment 8

[Fred Muyumba [:FredM]]

The issue is verified fixed on Flame 2.2 Master  KK (319mb) (Full Flash) and Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: When finishing FTE, call forwarding icons do NOT display briefly

Comment 9

[Fred Muyumba [:FredM]]

The issue is also verified fixed on Flame 2.0 KK (319mb) (Full Flash)

Environmental Variables:
Device:Flame 2.0 KK (319mb) (Full Flash)
BuildID: 20141012000202
Gaia: 6effca669c5baaf6cd7a63c91b71a02c6bd953b3
Gecko: 54ec9cb26b59
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Result: When finishing FTE, call forwarding icons do NOT display briefly