Closed Bug 1061942 Opened 6 years ago Closed 6 years ago

Switch back security/certverifier and security/manager to use unified builds

Categories

(Core :: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan.akhgari
Blocks: unified
Attachment #8483030 - Flags: review?(brian)
Comment on attachment 8483030 [details] [diff] [review]
Switch back security/certverifier and security/manager to use unified builds

Review of attachment 8483030 [details] [diff] [review]:
-----------------------------------------------------------------

I recommend looking at the patch I used to switch from UNIFIED_SOURCES -> SOURCES, to see if you should be more selective in what you switch from SOURCES -> UNIFIED_SOURCES. IIRC, some sources were already excluded from UNIFIED_SOURCES, but I don't remember for sure whether it was these directories or not. Consequently, please do a full try run before pushing the final version of this patch to inbound.

::: security/manager/ssl/src/moz.build
@@ +83,4 @@
>          'nsCertTree.cpp',
>      ]
>  
> +UNIFIED_SOURCES += [

Is UNIFIED_SOURCES smart enough to recognize that this is a *.c file and not a *.cpp file?
Attachment #8483030 - Flags: review?(brian) → review+
(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #2)
> Comment on attachment 8483030 [details] [diff] [review]
> Switch back security/certverifier and security/manager to use unified builds
> 
> Review of attachment 8483030 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I recommend looking at the patch I used to switch from UNIFIED_SOURCES ->
> SOURCES, to see if you should be more selective in what you switch from
> SOURCES -> UNIFIED_SOURCES. IIRC, some sources were already excluded from
> UNIFIED_SOURCES, but I don't remember for sure whether it was these
> directories or not.

Yeah, I basically reverted the respective sections of your patch by hand.  :-)

> Consequently, please do a full try run before pushing
> the final version of this patch to inbound.

Certainly.

> ::: security/manager/ssl/src/moz.build
> @@ +83,4 @@
> >          'nsCertTree.cpp',
> >      ]
> >  
> > +UNIFIED_SOURCES += [
> 
> Is UNIFIED_SOURCES smart enough to recognize that this is a *.c file and not
> a *.cpp file?

Yes.  We group the files into unified buckets based on their extension.  So, C files go into Unified_c_foo_barN.c, cpp files go to Unified_cpp_foo_barN.cpp, etc.
https://hg.mozilla.org/mozilla-central/rev/a34dfd7c025d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.