Closed Bug 939583 (unified) Opened 7 years ago Closed 4 years ago

Build the tree in unified mode

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ehsan, Assigned: ehsan)

References

(Depends on 2 open bugs, )

Details

I am planning to use this bug to keep track of the effort to port the tree to unified builds.
Depends on: 939569
Depends on: 938864
Depends on: 938867
Depends on: 939296
Depends on: 938859
Depends on: 938850
Depends on: 938848
Depends on: 939451
Depends on: 938849
Depends on: 936912
Depends on: 938134
Depends on: 937908
Depends on: 938852
Depends on: 938114
Depends on: 938123
Depends on: 939582
Depends on: 939571
Depends on: 938869
Depends on: 939580
Depends on: 939303
Depends on: 938844
Depends on: 938853
Depends on: 938865
Depends on: 939538
Depends on: 939572
Depends on: 939576
Depends on: 939578
Depends on: 939121
Depends on: 938970
Depends on: 937886
Depends on: 939585
Depends on: 939584
Depends on: 939588
Depends on: 939596
Depends on: 939608
Depends on: 939609
Depends on: 939611
OS: Mac OS X → All
Hardware: x86 → All
Depends on: 939659
Depends on: 939795
Depends on: 939950
Depends on: 940117
Depends on: 940153
Depends on: 940178
Depends on: 940185
Depends on: 940189
Depends on: 940194
Depends on: 940207
Depends on: 940215
Depends on: 940218
Depends on: 940225
Depends on: 940226
Depends on: 940235
Depends on: 940407
Depends on: 940416
Depends on: 940591
Depends on: 940708
Depends on: 940780
Depends on: 940793
Depends on: 940799
Depends on: 940832
Depends on: 940934
Is there a global flag to turn these changes off?

They seem to be causing trouble in debuggers (like gdb and lldb).
(In reply to comment #2)
> Is there a global flag to turn these changes off?

No, but you can use a command like below locally:

$ find . -name moz.build | xargs  grep -w UNIFIED_SOURCES | awk -F: '{print $1}' | sort | uniq | xargs sed -i 's/UNIFIED_SOURCES/SOURCES/'

> They seem to be causing trouble in debuggers (like gdb and lldb).

Hmm, this should only affect lldb (and it's a known limitation of that tool, see <http://lldb.llvm.org/troubleshooting.html>.  Does this really affect gdb for you?
Actually I haven't seen the problem myself.  Someone else reported it, whose using lldb via XCode (5.0.1) on Mavericks.

I still think we should have a global flag, though -- ideally a configure option, but at least a define.
Depends on: 941090
(In reply to comment #4)
> Actually I haven't seen the problem myself.  Someone else reported it, whose
> using lldb via XCode (5.0.1) on Mavericks.
> 
> I still think we should have a global flag, though -- ideally a configure
> option, but at least a define.

Sure, please file a bug!
Depends on: 941097
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> (In reply to comment #4)
> > Actually I haven't seen the problem myself.  Someone else reported it, whose
> > using lldb via XCode (5.0.1) on Mavericks.
> > 
> > I still think we should have a global flag, though -- ideally a configure
> > option, but at least a define.
> 
> Sure, please file a bug!

Nevermind, I filed bug 941097 myself.
Depends on: 941332
Depends on: 941406
Depends on: 941417
Depends on: 941424
Depends on: 941590
Depends on: 941599
Depends on: 941539
Depends on: 941693
Depends on: 941728
Depends on: 941732
Depends on: 941782
Depends on: 941824
Depends on: 941854
Depends on: 941866
Depends on: 942033
Depends on: 942122
Depends on: 942124
Depends on: 942127
Depends on: 942167
Depends on: 942193
Depends on: 942137
Depends on: 942248
Depends on: 942334
Depends on: 942486
Depends on: 942489
Depends on: 942537
Depends on: 942633
Depends on: 942635
Depends on: 943023
Depends on: 943156
Depends on: 943347
Depends on: 943355
Depends on: 943208
Depends on: 943695
Depends on: 943712
Depends on: 943719
Depends on: 943982
Depends on: 943983
Depends on: 943984
Depends on: 943988
Depends on: 943990
Depends on: 943993
Depends on: 943994
Depends on: 943995
Depends on: 943999
Depends on: 944000
Depends on: 944002
Depends on: 944003
Depends on: 944004
Depends on: 943686
Depends on: 928231
Depends on: 944209
Depends on: 944212
Depends on: 944378
Depends on: 944379
Depends on: 944380
Depends on: 944830
Depends on: 944834
Depends on: 944835
Depends on: 944844
Depends on: 944961
Depends on: 944962
Depends on: 944977
Depends on: 945118
Depends on: 945496
Depends on: 945587
Depends on: 945588
Depends on: 945589
Depends on: 945590
Depends on: 945592
Depends on: 946209
Depends on: 946210
Depends on: 946212
Depends on: 946214
Depends on: 946216
Depends on: 946217
Depends on: 946218
Depends on: 946219
Depends on: 946221
Depends on: 946576
Depends on: 947734
Depends on: 947735
Depends on: 947736
Depends on: 947737
Depends on: 947979
Depends on: 948777
Depends on: 950503
Depends on: 950505
Depends on: 950506
Depends on: 950507
Depends on: 950508
Depends on: 950676
Depends on: 951537
No longer depends on: 951537
Depends on: 1028420
Depends on: 1029678
Depends on: 1061942
Depends on: 1072289
Depends on: 1072294
Depends on: 1072299
Depends on: 1072301
Depends on: 1072310
Depends on: 1072700
Depends on: 1072701
Depends on: 806819
Depends on: 1084369
Depends on: 1111225
Depends on: 1140763
Depends on: 1140765
Depends on: 1140766
Depends on: 1140767
Depends on: 1140771
Depends on: 1146204
Depends on: 1146888
Depends on: 1147242
Depends on: 1147243
Depends on: 1192587
Depends on: 1194948
Depends on: 1195186
Component: Tracking → Build Config
I think this is sufficiently FIXED. Further work can be tracked in other bugs.
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1348991
Depends on: 1348998
Depends on: 1349002
Depends on: 1350423
Depends on: 1351820
Depends on: 1351831
Depends on: 1351910
Depends on: 1362644
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.