1061995 - Keep forcing windowless plugin mode in e10s

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[John Schoenick [:johns]]

Bug 853995 cleaned up the plugin parameters code and inadvertently dropped the bug 923745 workaround to force flash to windowless mode until windowed mode works again

Comment 1

[John Schoenick [:johns]]

Attachment: Restore bug 923745 workaround for windowless flash in e10s mode

Comment 2

[John Schoenick [:johns]]

Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8283057311

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d8283057311

Comment 4

[John Schoenick [:johns]]

Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode

I guess we should nom this on the off chance someone wants to e.g. bisect something on aurora, it doesn't have any effect on non-e10s mode regardless

Approval Request Comment
[Feature/regressing bug #]: Bug 853995 inadvertently dropped this workaround

[User impact if declined]: e10s plugins are (even more) broken. Not sure that anyone should be using e10s mode on aurora, but the check only affects e10s mode either way.

[Describe test coverage new/current, TBPL]: None, plugins aren't passing in e10s tests yet

[Risks and why]: None, e10s-only, and just restoring chunk of code inadvertently removed in 34
 
[String/UUID change made/needed]: None

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode

I think we're still early enough where we can to put back this chunk of code in Aurora. Approved.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9adeeef7fafe