1062087 - SettingsRequestManager showing undefined variable errors on B2G Boot

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

E/GeckoConsole(  304): [JavaScript Warning: "reference to undefined property msg.isServiceLock" {file: "resource://gre/modules/SettingsRequestManager.jsm" line: 868}]
E/GeckoConsole(  304): [JavaScript Warning: "reference to undefined property ret.results" {file: "resource://gre/modules/SettingsRequestManager.jsm" line: 649}]

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Fix undefined variable errors in SettingsRequestManager

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8484589 [details] [diff] [review]
Patch 1 (v1) - Fix undefined variable errors in SettingsRequestManager

Review of attachment 8484589 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsRequestManager.jsm
@@ -601,4 @@
>            p.reject("Invalid operation: " + currentTask.operation);
>        }
>        p.then(function(ret) {
> -        ret.task.defer.resolve(ret.results);

Couldn't this just become |"results" in ret ? ret.results : null|

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

[Blocking Requested - why for this release]: Harmless but looks really bad.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Fix undefined variable errors in SettingsRequestManager (r=bent)

Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Error messages reported regularly that look really bad
[Describe test coverage new/current, TBPL]: Ran against multiple builds, no sign of error message. Also ran mochis, was green.
[Risks and why]: None 
[String/UUID change made/needed]: None

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Made recommended fix, landed.

https://hg.mozilla.org/integration/b2g-inbound/rev/e678b63afaa1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e678b63afaa1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/348fd67ac292