1062537 - Specify --with-android-min-sdk=15 for x86 builds

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Richard Newman [:rnewman]]

As far as I can tell, the earliest supported Android SDK version for x86 devices is JB (16).

We should specify the new build flags for min=16 in our x86 builds. Right now that'll result in smaller, faster output code; eventually it will also minimize shipped resources.

Someone with more data than I have can correct me if we should really target a lower minimum.

Comment 1

[Richard Newman [:rnewman]]

Can we find this out from FHR?

For all v3 payloads:

Filter:

  environments/current/org.mozilla.sysinfo.sysinfo/architecture = x86

Bucket count on

  environments/current/org.mozilla.sysinfo.sysinfo/version

which will be strings like "4.1.2".

Comment 2

[Richard Newman [:rnewman]]

Attachment: Specify --with-android-min-sdk=16 for x86 builds. v1

Comment 3

[Richard Newman [:rnewman]]

mfinkle provides!

99.9% of our x86 user base is on 15+.

The lowest API version is 10. Next after that is 13, then 15.

Comment 4

[Richard Newman [:rnewman]]

mfinkle, blassey: care to opine?

Comment 5

[Richard Newman [:rnewman]]

tmary supplied even more data: <15 is 0.056% of the x86 user base.

Cumulative percentages:

2.2.2      0.02%
2.3.1      0.02%
2.3.7      0.03%
3.2        0.06%
4.0.3      0.06%
4.0.4      4.16%
4.0.4      4.16%
4.1.1      4.32%
4.1.2      17.20%
4.1.2      17.20%
4.1.2      17.20%
4.1.2      17.20%
4.1.2      17.21%
4.2        17.21%
4.2.0      17.21%
4.2.1      19.79%
4.2.2      73.58%
4.3        90.57%
4.3.1      90.58%
4.3.2      90.58%
4.3.9      90.58%
4.4        90.58%
4.4.0      90.58%
4.4.2      99.95%
4.4.3      99.96%
4.4.4      100.00%
4.4.9      100.00%
4.4        100.00%
5.0.1      100.00%

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I honestly don't know how much benefit we'd get from this. The population is very small (<2% for all x86), so I don't know that it's worth doing anything right now.

I think we should focus on getting the "gingerbread phone" build created first.

Comment 7

[Richard Newman [:rnewman]]

This is something of a fatfennec issue, albeit only for x86 users.

Comment 8

[Richard Newman [:rnewman]]

Maybe a good first step for Bug 1155801? mfinkle, should we do this?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #8)
> Maybe a good first step for Bug 1155801? mfinkle, should we do this?

Too many pots on the stove. Let's just get bug 1155801 (and friends) finished first.

Comment 10

[Richard Newman [:rnewman]]

With that bug landed, we are close to this being done.

But in order to eliminate Honeycomb compat code (which we now wouldn't be testing on ARM), and resolve Bug 1217675, we need to bump x86 to either v14 or v15. I propose bumping straight to v15.

I suggest doing this in the same cycle as dropping ARM Honeycomb support to reduce the risk of Play doing something crazy.

Comment 11

[Richard Newman [:rnewman]]

Attachment: Specify --with-android-min-sdk=15 for x86 builds. v1

This bumps all x86 mozconfigs.

Comment 12

[Richard Newman [:rnewman]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ea59987a586

Comment 13

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8703057 [details] [diff] [review]
Specify --with-android-min-sdk=15 for x86 builds. v1

Review of attachment 8703057 [details] [diff] [review]:
-----------------------------------------------------------------

Technically there is no issue here.  Please post to the mailing list (of course).  I expect the Wiki wants updating, although I don't know where off-hand.  I see the MDN documentation is fresh at https://developer.mozilla.org/en-US/docs/Simple_Firefox_for_Android_build.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8703057 [details] [diff] [review]
Specify --with-android-min-sdk=15 for x86 builds. v1

LGTM

Comment 15

[Richard Newman [:rnewman]]

Updated MDN, the wiki, and SUMO:

https://developer.mozilla.org/en-US/docs/Simple_Firefox_for_Android_build$revision/982989
https://support.mozilla.org/en-US/kb/will-firefox-work-my-mobile-device/revision/113221
https://wiki.mozilla.org/index.php?title=Mobile%2FPlatforms%2FAndroid&diff=1111060&oldid=1069880
https://wiki.mozilla.org/index.php?title=Mobile/Fennec/Android&diff=prev&oldid=1111061

Comment 16

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/82c0daba6032b5cd3fae7ffcae0fce4776e6a860
Bug 1062537 - Pre: correct comments in android_version_code.py.

https://hg.mozilla.org/integration/fx-team/rev/30c5cd7a3ec750909be74cc68473a6e30ee7f6e6
Bug 1062537 - Specify --with-android-min-sdk=15 for x86 builds. r=nalexander,mfinkle

Comment 17

[Richard Newman [:rnewman]]

Email sent to release-drivers and mobile-firefox-dev:

https://mail.mozilla.org/pipermail/mobile-firefox-dev/2016-January/001672.html

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82c0daba6032
https://hg.mozilla.org/mozilla-central/rev/30c5cd7a3ec7