Inline the activity options used in the wappush app in order to make it easier to automatically extract the activity arguments from the source code

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::Dialer
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 1 bug)

unspecified
2.1 S4 (12sep)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1062564 +++

I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code.  It's much simper for this tool if the activity options argument was passed as an inline JS object.  I have a simple patch which does this for the wappush app.
(Assignee)

Comment 1

3 years ago
Created attachment 8483771 [details] [review]
Patch (v1)
Attachment #8483771 - Flags: review?(timdream)
Comment on attachment 8483771 [details] [review]
Patch (v1)

Actually for wappush :gsvelto should review but this looks trivial anyway.

Please make sure linter passes.
Attachment #8483771 - Flags: review?(timdream) → review+
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> Actually for wappush :gsvelto should review but this looks trivial anyway.

Yeah, no problem with that. BTW I had culled this code from the SMS app and left it unmodified to reduce the risk because this was crash-landed during the infamous Oslo work-week so if you've got a change for the SMS app working then the same should apply here.
(Assignee)

Comment 4

3 years ago
(In reply to Gabriele Svelto [:gsvelto] from comment #3)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from
> comment #2)
> > Actually for wappush :gsvelto should review but this looks trivial anyway.
> 
> Yeah, no problem with that. BTW I had culled this code from the SMS app and
> left it unmodified to reduce the risk because this was crash-landed during
> the infamous Oslo work-week so if you've got a change for the SMS app
> working then the same should apply here.

Yes, I came across that code in the SMS app too.  The problem there is that tryActivity has several callers, each passing different activity options.  I would like to do something there too because that is currently the only place in gaia where my static analysis fails...
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/0c80770e538404b874741c06595ea8c65b66e1e3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
You need to log in before you can comment on or make changes to this bug.