1062656 - Remove user-specified preferences for all unsupported skins

Status: RESOLVED FIXED

(Websites :: wiki.mozilla.org, defect)

Description

[Christie Koehler [:ckoehler]]

As part of the 1.23 upgrade, we're removing an user-set preference for unsupported skins. Any user who has set a skin preference for something other than monobook and vector will have that preference removed and see Vector when they log in (which is now the default skin). 

Here's the SQL to accomplish this:
DELETE FROM user_properties WHERE up_property = 'skin' AND up_value IN ('cavendish', 'modern', 'cologneblue', 'standard', 'myskin', 'chick', 'sandstone', 'nostalgia', 'simple', 'gmo', '');

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Christie Koehler [:ckoehler] from comment #0)
> Here's the SQL to accomplish this:
> DELETE FROM user_properties WHERE up_property = 'skin' AND up_value IN
> ('cavendish', 'modern', 'cologneblue', 'standard', 'myskin', 'chick',
> 'sandstone', 'nostalgia', 'simple', 'gmo', '');

I'm sure it'd accomplish the same thing, but might it be better to specify it the opposite way?

DELETE FROM user_properties WHERE up_property = 'skin' AND up_value NOT IN ('vector', 'monobook');

Comment 2

[C. Liang [:cyliang]]

Erring on the side of caution, I chose to execute the first statement (which is explicit about what is deleted).  This SQL statement  was issued on the dev, stage, and production environments.

Comment 3

[Gordon P. Hemsley [:GPHemsley]]

(In reply to C. Liang [:cyliang] from comment #2)
> Erring on the side of caution, I chose to execute the first statement (which
> is explicit about what is deleted).

I actually believe that the query in comment 1 was the one erring on the side of caution, but I've filed bug 1063882 to confirm that the effect is the same.