1062825 - Logviewer: Page title should include job details to make tabs recognisable

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

The log viewer page title is always:
"Treeherder Log Viewer"

We should make it include details about the job, so multiple open tabs can be differentiated.

eg: Log viewer - <job type/platform> - <repo or timestamp or something>

Comment 1

[Jonathan French (:jfrench)]

Based on what's in the artifact header, I think we could do something like this example:

"Log viewer - Ubuntu VM 12.04 x64 mozilla-central pgo test mochitest-e10s-devtools-chrome"

Or we could append the buildid or starttime to the end, if you didn't mind it being longer:

eg.
"Log viewer - Ubuntu VM 12.04 x64 mozilla-central pgo test mochitest-e10s-devtools-chrome - 20141103043009"

or:
"Log viewer - Ubuntu VM 12.04 x64 mozilla-central pgo test mochitest-e10s-devtools-chrome - Mon Nov 03 2014 08:43:07 GMT-0500 (Eastern Standard Time)"

I assume the intent is to have it readable on tab hover anyway.

Comment 2

[Ed Morley [:emorley]]

I like this:

> "Log viewer - Ubuntu VM 12.04 x64 mozilla-central pgo test
> mochitest-e10s-devtools-chrome"

I think anything too much longer and it will get hard to read (and we can always add more, if in the future people say they find it hard to tell tabs or bookmarked log viewer pages apart :-))

Comment 3

[Jonathan French (:jfrench)]

Ok, thanks Ed, sounds good. I'll make the change.

Comment 4

[Jonathan French (:jfrench)]

I noticed there is also an {{angular}} flicker in the tab, as the page loads. If I can sort that out like we did with the ng-cloak for the angular body elements, I'll open a PR.

Comment 5

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#269

Please see the above PR for review and status.

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/ef3ffcb427ea94f8f2d66598bf85d2614bc95e1a
Bug 1062825 - Include job details in Logviewer page title

https://github.com/mozilla/treeherder-ui/commit/077a82ade8ad2f36eae15a5e37f9ead9b0817b0b
Merge pull request #269 from tojonmz/logviewer-page-title

Bug 1062825 - Include job details in Log viewer page title

Comment 7

[Jonathan French (:jfrench)]

Verified fixed and working correctly on dev in both Firefox and Chrome.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4f1c6852b371222e3238a32dabd1bc6f5dda2c1f
Bug 1062825 - Include job details in Logviewer page title

https://github.com/mozilla/treeherder/commit/2df8878561c6b5128fd00c783106e42aa4291c51
Merge pull request #269 from tojonmz/logviewer-page-title

Bug 1062825 - Include job details in Log viewer page title