1062856 - [ISE] Internal Server Error previewing any API Reference page

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect, P1)

Description

[Eric Shepherd [:sheppy]]

What did you do?
================
1. Visited https://developer.mozilla.org/en-US/docs/Web/API/IDBFactory
2. Clicked Edit button.
3. Clicked Preview button.

What happened?
==============
Got an internal server error.

What should have happened?
==========================
A preview of the page should have appeared.

Is there anything else we should know?
======================================
Also happens for sure on:

https://developer.mozilla.org/en-US/docs/Web/API/Performance
https://developer.mozilla.org/en-US/docs/Web/API/Window
https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement

and more

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

I can confirm that we get an ISE. Luke, can you tell us whether this bug is affecting a lot of people, and can you tell us what the stack says about this?

:teoli and :fscholz think this may be a regression that appeared in the last couple of weeks.

Comment 2

[Luke Crouch [:groovecoder]]

39 errors in the last week.

Comment 3

[Eric Shepherd [:sheppy]]

It's worth noting of course that once someone figures out that clicking "Preview" always gets them an Internal Server Error, they will stop clicking it. :)

Comment 6

[Luke Crouch [:groovecoder]]

Tracebacks look like:

Traceback (most recent call last):
File "/usr/lib64/python2.6/site-packages/newrelic-2.22.1.20/newrelic/hooks/framework_django.py", line 492, in wrapper return wrapped(*args, **kwargs)
File "/data/www/developer.mozilla.org/kuma/apps/access/decorators.py", line 46, in _wrapped_view return view_fn(request, *args, **kwargs)
File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/views/decorators/http.py", line 41, in inner return func(request, *args, **kwargs)
File "/data/www/developer.mozilla.org/kuma/kuma/wiki/views.py", line 1339, in preview_revision return render(request, 'wiki/preview.html', data)
File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/shortcuts/__init__.py", line 44, in render return HttpResponse(loader.render_to_string(*args, **kwargs),
File "/data/www/developer.mozilla.org/kuma/vendor/src/django/django/template/loader.py", line 176, in render_to_string return t.render(context_instance)
File "/data/www/developer.mozilla.org/kuma/vendor/src/jingo/jingo/__init__.py", line 191, in render return super(Template, self).render(context_dict)
File "/usr/lib64/python2.6/site-packages/newrelic-2.22.1.20/newrelic/api/function_trace.py", line 96, in dynamic_wrapper return wrapped(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render return self.environment.handle_exception(exc_info, True)
File "/data/www/developer.mozilla.org/kuma/kuma/wiki/templates/wiki/preview.html", line 3, in top-level template code {% set classes = 'document' %}
File "/data/www/developer.mozilla.org/kuma/kuma/wiki/templates/wiki/base.html", line 14, in top-level template code {% set scripts = ('wiki',) %}
File "/data/www/developer.mozilla.org/kuma/templates/base.html", line 161, in top-level template code {% block content %}{% endblock %}
File "/data/www/developer.mozilla.org/kuma/kuma/wiki/templates/wiki/preview.html", line 9, in block "content" {% include 'wiki/includes/kumascript_errors.html' %}
File "/data/www/developer.mozilla.org/kuma/kuma/wiki/templates/wiki/includes/kumascript_errors.html", line 50, in top-level template code {{ _('Parsing macro:') }} <code>{{ template_name }}({% if error_meta.token %}{{ error_meta.token.args }}{% endif %})</code> (<a href="{{ url('wiki.edit_document', document.slug) }}">{{ _('Edit Document') }}</a>)<br>
File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 371, in getattr return getattr(obj, attribute)
UndefinedError: 'document' is undefined 

From https://rpm.newrelic.com/accounts/263620/applications/3172075/traced_errors/2363939509

Comment 7

[ali spivak]

Bumping based on email on MDN-drivers list from Nickolay Ponomarev

"This is a regression in basic wiki functionality that affects a large
number of pages. I'd expect it to have a higher priority - it has been
sitting there untouched for a month."

Comment 8

[David Walsh :davidwalsh]

PR is in for this.  I didn't see it come in originally.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0f1d4630ec0c10f0efca412cd9d4251e4f13f417
fix bug 1062856 - Prevent ISE on kumascript errors within preview

https://github.com/mozilla/kuma/commit/386a7e630d2589ad8eb98629ade38c7853aae780
Merge pull request #2822 from groovecoder/ks-preview-ise-1062856

fix bug 1062856 - Prevent ISE on kumascript errors within preview