1062940 - Please increase bmo's alias length to match bugzilla 5.0 (40 chars instead of 20)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Justin Wood (:Callek)]

Per IRC this should be easily doable though it involves edits to many files since its not a const (at least now)

I was told that Bugzilla 5.0 uses 40 chars instead of 20, so lets go with that.

This will require a schema change

Comment 1

[David Lawrence [:dkl]]

Attachment: 1062940_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8499824 [details] [diff] [review]
1062940_1.patch

Review of attachment 8499824 [details] [diff] [review]:
-----------------------------------------------------------------

you also need to update show_bug's input field to increase the maxlength to 40.

Comment 3

[David Lawrence [:dkl]]

Attachment: 1062940_2.patch

Comment 4

[:glob ✱]

Comment on attachment 8508710 [details] [diff] [review]
1062940_2.patch

Review of attachment 8508710 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob with the change to size="30" and s/maxsize/maxlength/

even though there's a schema change, it's ok to commit this patch all at once.

::: template/en/default/bug/create/create.html.tmpl
@@ +455,4 @@
>        field = bug_fields.alias editable = 1
>      %]
>      <td colspan="2">
> +      <input name="alias" size="40" maxsize="40" value="[% alias FILTER html %]">

size="40" here looks messy, because it's a different size from the other inputs on create bug.  use size="30" so it aligns with the assignee, cc, and depend on fields.

maxsize isn't valid, you want maxlength.

Comment 5

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0e1bc26..09ff8ee  master -> master

Comment 6

[Ed Morley [:emorley]]

Ah this is great - only yesterday was I struggling to fit the desired terms for a meta bug in the alias field :-)