1063177 - "+" button overlaps text in long search suggestions

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[:Margaret Leibovic]

To fix this, we need to tweak this layout:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/res/layout/search_suggestions_row.xml

Probably this shouldn't be a FrameLayout. I would try making it a LinearLayout and see if that fixes things.

Comment 1

[:Margaret Leibovic]

Actually, I'm just going to fix this myself :)

Comment 2

[:Margaret Leibovic]

Attachment: Don't let plus button overlap search suggestion text

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8484558 [details] [diff] [review]
Don't let plus button overlap search suggestion text

Review of attachment 8484558 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/search/res/layout/search_suggestions_row.xml
@@ +9,5 @@
>      android:background="@drawable/search_card_background"
>      android:paddingTop="0dp"
>      android:paddingBottom="0dp"
>      android:descendantFocusability="blocksDescendants"
>      android:orientation="horizontal">

Heh, funny that we already had an orientation for a FrameLayout.

Comment 4

[:Margaret Leibovic]

(In reply to Brian Nicholson (:bnicholson) from comment #3)
> Comment on attachment 8484558 [details] [diff] [review]
> Don't let plus button overlap search suggestion text
> 
> Review of attachment 8484558 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/search/res/layout/search_suggestions_row.xml
> @@ +9,5 @@
> >      android:background="@drawable/search_card_background"
> >      android:paddingTop="0dp"
> >      android:paddingBottom="0dp"
> >      android:descendantFocusability="blocksDescendants"
> >      android:orientation="horizontal">
> 
> Heh, funny that we already had an orientation for a FrameLayout.

Yeah, I think this was actually a LinearLayout originally, and I think I made it a FrameLayout when the button was different. In any case, it's sorted out now! :)

https://hg.mozilla.org/integration/fx-team/rev/46dfee14106a
https://github.com/mozilla/fennec-search/commit/3ec58963443ea6963abec1aeb4af9a80048aaea4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46dfee14106a

Comment 6

[Flaviu Cos]

Verified as fixed in build 35.0a1 (2014-10-02);
Device: Motorola Razr (Android 4.1.2).