1063284 - Log at higher level when killing interrupted sql commands

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

We currently log some DEBUG-level messages when killing a mysql query due to timeout.  They don't show up in production logs by default.  This should be rare enough and is useful enough to know about, that it's worth logging at WARN instead.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: sync-log-at-higher-level-on-query-kill.diff

This patch switches all the relevant log statements from "debug" to "warn".

Comment 2

[Dan Callahan [:callahad]]

Comment on attachment 8487642 [details] [diff] [review]
sync-log-at-higher-level-on-query-kill.diff

Review of attachment 8487642 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/30afe77afd9947b268f91b9f3a9c7bd9540c3df1

Bob, this should allow logs about killing mysql queries to appear in production, so we should start watching out for them to get a feel for what frequency etc is.

Comment 4

[Bob Micheletto [:bobm]]

(In reply to Ryan Kelly [:rfkelly] from comment #3)
> Bob, this should allow logs about killing mysql queries to appear in
> production, so we should start watching out for them to get a feel for what
> frequency etc is.

Excellent.  When the next version is rolled out, we'll add it to the Sync app log graphs.