1063311 - [Contacts] Warning page does not work when tap email in user contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Edward Chen[:edchen]]

[Device]
Flame

[Environment]
Gaia      a47ecb6368c015dd72148acde26413fd90ba3136
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/757931d0149e
BuildID   20140904000203
Version   34.0a2
ro.build.version.incremental=eng.cltbld.20140820.195518
ro.build.date=Wed Aug 20 19:55:28 EDT 2014

[STR]
1. Prepare user date in contact, include email information
2. Launch contact app
3. tap the user's email
4. The warning page is pop up.

[Actually result]
1. the OK and cancel buttons are not work

[Expected result]
1. The buttons have to work
2. After click OK, might be launch email app to set account is better.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

What we display is the web activity for email, that is working.

If you don't have an email account, you have an alert from the email app to tell you about to configure an email account.

BTW, that alert is working for me.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 3

[Cody Roesch [:croesch]]

I was able to reproduce the issue but I need to revise the steps just a little.

Prerequisite: Do NOT have an Email account set up on the device.

STR:
1. Launch Contacts and create a contact that includes an email account and tap DONE.
2. Tap the contact to go to the details then tap the Email address.
3. The user is taken to the Email app and shown a Confirmation message about setting up an email account.
4. Tap Cancel
5. Tap the contacts Email account again to go back to the email confirmation message.
6. Notice the Cancel and the OK buttons do not work anymore in the confirmation page.

Repro Rate: 5/5

This bug repro's on: Flame 2.2, Flame 2.1, OpenC 2.2

Actual Results: Cancel and OK buttons on the Email confirmation page stop working

Repro Rate: 6/6

Environmental Variables:
Device: Flame Master
BuildID: 20140908062801
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: f7a27a866c47
Version: 35.0a1 (Master) 
Firmware Version: v123
-----------------------------------------------
Environmental Variables:
Device: Flame 2.1
BuildID: 20140908022757
Gaia: e7ac3a51932f7f7a5b5a6935dcaad1343b7c5fa5
Gecko: d1b97cc46b5a
Version: 34.0a2
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Open_C Master
BuildID: 20140908062801
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: f7a27a866c47
Version: 35.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

------------------------------------------------
------------------------------------------------

This bug does NOT repro on: Flame 2.0, Flame 1.4

Actual Result: Cancel and OK buttons work everytime in the Email confirmation window when arrving through an email address in contacts.

Repro Rate: 0/6 attempts

Environmental Variables:
Device: Flame 2.0
BuildID: 20140906031700
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140905100238
Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54
Gecko: a3e8df746cd8
Version: 30.0 (1.4) 
Firmware Version: v123

Comment 4

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: regression - non-working buttons

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Changing component to email, since that screen is being displayed by this application

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140814151215
Gaia: 5bd72883a5f0c902b0791390d395478863fe723f
Gecko: f7b6d6ec16d4
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140814161216
Gaia: f695792496326679702a0b2f48a9c384fd47473a
Gecko: f483823a572d
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & Last working gaia - issue does NOT repro
Gaia: 5bd72883a5f0c902b0791390d395478863fe723f
Gecko: f483823a572d

First broken gaia & Last working gecko - issue DOES repro
Gaia: f695792496326679702a0b2f48a9c384fd47473a
Gecko: f7b6d6ec16d4

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/5bd72883a5f0c902b0791390d395478863fe723f...f695792496326679702a0b2f48a9c384fd47473a

Caused by Bug 1050725.

Comment 7

[Joshua Mitchell (Inactive)]

Broken by Bug 1050725 ? James, can you take a look?

Comment 8

[Candice Serran (:cserran)]

blocker justification: regression -> can't configure email

Comment 9

[James Burke [:jrburke]]

Attachment: GitHub pull request

Reverts the change done in bug 1050725. I tried investigating why it causes the problem:

In Cards.removeCardAndSuccessors(), which is called by the ConfirmDialog.cancel at some point, the deadCardInsts handling inside it, schedules the DOM nodes to be removed from the via _animatingDeadDomNodes, so the cancel nodes are still in the DOM.

They are 'immediate' transitions though, so in the switch for the showMethod, I tried just removing them immediately if the showMethod was 'immediate'. This seemed to be a way to fix the problem, and likely what we want to do long term.

I tried figuring out why this transition CSS change ends up with the dialog in front, but the webide tooling conspired against me, at some points showing me stale DOM, so I do not trust its state, and I am currently worn out dealing with this sort of dependency quicksand.

From what I could tell, both before and after this change the confirm dialogs should be behind the setup_account_info card that gets pushed eventually when flipping to the email app. So it should have all worked out, but obviously it didn't.

Since this will be uplifted to the 2.1 branch, and we are trying to minimize risk, better to just revert than to introduce a more fundamental change in the card logic. I will reopen bug 1050725 if this lands, and reference this issue for further investigation.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8487537 [details] [review]
GitHub pull request

r=asuth to revert that.  This is probably impacting layerization and thereby impacting click handling.  Apologies about the delay.  Amending daily first-tasks policy...

Comment 11

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/61d0c951d3563a34e4397d0c9db1cdab0c500d4d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/23919

Comment 12

[James Burke [:jrburke]]

Comment on attachment 8487537 [details] [review]
GitHub pull request

[Bug caused by] (feature/regressing bug #):
bug 1050725

[User impact] if declined:
User cannot configure an email account if they trigger this activity+cancel flow.

[Testing completed]:
Tested on flame device.

[Risk to taking this patch] (and alternatives if risky):
Very low. A CSS-only change. This is how it worked before the patch from bug 1050725, and that CSS has been used for a few releases now. 

[String changes made]:
none.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0c0fd39031398947f34d332b791297d59f9ca004

Comment 14

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/2c6e3261c47b
Build ID        20140921160204
Version         34.0a2
Device Name     flame
FW-Release      4.3
FW-Incremental  110
FW-Date         Fri Jun 27 15:57:58 CST 2014
Bootloader      L1TC00011230

[Result]
PASS

Comment 15

[John Thomas [:Johnt]]

This issue is verfied fixed for the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Email warning page works correctly.