Closed
Bug 1063461
Opened 11 years ago
Closed 11 years ago
Remove keyboard_manager.js from linter xfail list
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: mnjul, Assigned: mnjul)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
After all those code tidying-up and refactoring with the input management script tracked by bug 1053041, we're close to a point where keyboard_manager.js is "clean" enough to be linter-checked by jshint instead of the current gjslint. This bug will carry out the process.
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Rudy,
Would you review this very quick patch on this bug and bug 1063457? Those are nice-to-have tidy-ups for input management script. Thanks!
Attachment #8492044 -
Flags: review?(rlu)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jlu
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8492044 [details] [review]
Patch (PR @ GitHub)
Looks good to me.
Thanks.
Attachment #8492044 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•